Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: chrome/browser/content_settings/host_content_settings_map.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Maps hostnames to custom content settings. Written on the UI thread and read 5 // Maps hostnames to custom content settings. Written on the UI thread and read
6 // on any thread. One instance per profile. 6 // on any thread. One instance per profile.
7 7
8 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_ 8 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_
9 #define CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_ 9 #define CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_
10 #pragma once 10 #pragma once
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 160
161 // NotificationObserver implementation. 161 // NotificationObserver implementation.
162 virtual void Observe(NotificationType type, 162 virtual void Observe(NotificationType type,
163 const NotificationSource& source, 163 const NotificationSource& source,
164 const NotificationDetails& details); 164 const NotificationDetails& details);
165 165
166 private: 166 private:
167 friend struct BrowserThread::DeleteOnThread<BrowserThread::UI>; 167 friend struct BrowserThread::DeleteOnThread<BrowserThread::UI>;
168 friend class DeleteTask<HostContentSettingsMap>; 168 friend class DeleteTask<HostContentSettingsMap>;
169 169
170 ~HostContentSettingsMap(); 170 virtual ~HostContentSettingsMap();
171 171
172 void UnregisterObservers(); 172 void UnregisterObservers();
173 173
174 // Various migration methods (old cookie, popup and per-host data gets 174 // Various migration methods (old cookie, popup and per-host data gets
175 // migrated to the new format). 175 // migrated to the new format).
176 void MigrateObsoleteCookiePref(PrefService* prefs); 176 void MigrateObsoleteCookiePref(PrefService* prefs);
177 177
178 // The profile we're associated with. 178 // The profile we're associated with.
179 Profile* profile_; 179 Profile* profile_;
180 180
(...skipping 19 matching lines...) Expand all
200 mutable base::Lock lock_; 200 mutable base::Lock lock_;
201 201
202 // Misc global settings. 202 // Misc global settings.
203 bool block_third_party_cookies_; 203 bool block_third_party_cookies_;
204 bool is_block_third_party_cookies_managed_; 204 bool is_block_third_party_cookies_managed_;
205 205
206 DISALLOW_COPY_AND_ASSIGN(HostContentSettingsMap); 206 DISALLOW_COPY_AND_ASSIGN(HostContentSettingsMap);
207 }; 207 };
208 208
209 #endif // CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_ 209 #endif // CHROME_BROWSER_CONTENT_SETTINGS_HOST_CONTENT_SETTINGS_MAP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698