net/disk_cache/entry_impl.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/entry_impl.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/entry_impl.h

diff --git a/net/disk_cache/entry_impl.h b/net/disk_cache/entry_impl.h

index 59901a885a743f38c6d422053b8d3bfd7378a046..830d426d34b7b128cf631948375a23f79a00d797 100644

--- a/net/disk_cache/entry_impl.h

+++ b/net/disk_cache/entry_impl.h

@@ -152,7 +152,7 @@ class NET_TEST EntryImpl : public Entry, public base::RefCounted<EntryImpl> {

};

class UserBuffer;

- ~EntryImpl();

+ virtual ~EntryImpl();

// Do all the work for ReadDataImpl and WriteDataImpl. Implemented as

// separate functions to make logging of results simpler.

« no previous file with comments | « net/disk_cache/backend_impl.h ('k') | net/disk_cache/file_lock.h » ('j') | no next file with comments »