Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/browser/autocomplete/history_contents_provider.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_HISTORY_CONTENTS_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_HISTORY_CONTENTS_PROVIDER_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_HISTORY_CONTENTS_PROVIDER_H_ 6 #define CHROME_BROWSER_AUTOCOMPLETE_HISTORY_CONTENTS_PROVIDER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "chrome/browser/autocomplete/history_provider.h" 9 #include "chrome/browser/autocomplete/history_provider.h"
10 #include "chrome/browser/history/history.h" 10 #include "chrome/browser/history/history.h"
(...skipping 17 matching lines...) Expand all
28 Profile* profile, 28 Profile* profile,
29 bool body_only); 29 bool body_only);
30 30
31 // As necessary asks the history service for the relevant results. When 31 // As necessary asks the history service for the relevant results. When
32 // done SetResults is invoked. 32 // done SetResults is invoked.
33 virtual void Start(const AutocompleteInput& input, 33 virtual void Start(const AutocompleteInput& input,
34 bool minimal_changes) OVERRIDE; 34 bool minimal_changes) OVERRIDE;
35 virtual void Stop() OVERRIDE; 35 virtual void Stop() OVERRIDE;
36 36
37 private: 37 private:
38 ~HistoryContentsProvider(); 38 virtual ~HistoryContentsProvider();
39 39
40 void QueryComplete(HistoryService::Handle handle, 40 void QueryComplete(HistoryService::Handle handle,
41 history::QueryResults* results); 41 history::QueryResults* results);
42 42
43 // Converts each MatchingPageResult in results_ to an AutocompleteMatch and 43 // Converts each MatchingPageResult in results_ to an AutocompleteMatch and
44 // adds it to matches_. 44 // adds it to matches_.
45 void ConvertResults(); 45 void ConvertResults();
46 46
47 // Creates and returns an AutocompleteMatch from a MatchingPageResult. 47 // Creates and returns an AutocompleteMatch from a MatchingPageResult.
48 AutocompleteMatch ResultToMatch(const history::URLResult& result, 48 AutocompleteMatch ResultToMatch(const history::URLResult& result,
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 // Whether results_ is valid (so we can tell invalid apart from empty). 96 // Whether results_ is valid (so we can tell invalid apart from empty).
97 bool have_results_; 97 bool have_results_;
98 98
99 // Current query string. 99 // Current query string.
100 string16 query_; 100 string16 query_;
101 101
102 DISALLOW_COPY_AND_ASSIGN(HistoryContentsProvider); 102 DISALLOW_COPY_AND_ASSIGN(HistoryContentsProvider);
103 }; 103 };
104 104
105 #endif // CHROME_BROWSER_AUTOCOMPLETE_HISTORY_CONTENTS_PROVIDER_H_ 105 #endif // CHROME_BROWSER_AUTOCOMPLETE_HISTORY_CONTENTS_PROVIDER_H_
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_popup_view_gtk.h ('k') | chrome/browser/autocomplete/history_quick_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698