net/socket/client_socket_pool_base.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_base.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/client_socket_pool_base.h

diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h

index eb9d2a2d7d3752878ffe6a06b5d69ea1dd6fdbdb..a5defdf74b60761144863dcaa58658a54274a048 100644

--- a/net/socket/client_socket_pool_base.h

+++ b/net/socket/client_socket_pool_base.h

@@ -219,7 +219,7 @@ class NET_TEST ClientSocketPoolBaseHelper

base::TimeDelta used_idle_socket_timeout,

ConnectJobFactory* connect_job_factory);

- ~ClientSocketPoolBaseHelper();

+ virtual ~ClientSocketPoolBaseHelper();

// See ClientSocketPool::RequestSocket for documentation on this function.

// ClientSocketPoolBaseHelper takes ownership of |request|, which must be

« no previous file with comments | « net/http/http_stream_parser.h ('k') | net/socket/client_socket_pool_manager.h » ('j') | no next file with comments »