net/tools/flip_server/sm_connection.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/flip_server/sm_connection.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/flip_server/sm_connection.h

diff --git a/net/tools/flip_server/sm_connection.h b/net/tools/flip_server/sm_connection.h

index 044f3113d0edd16e2eee838b5fb9887756485825..aa91890057c3e518e111c33ebe00143de1d08327 100644

--- a/net/tools/flip_server/sm_connection.h

+++ b/net/tools/flip_server/sm_connection.h

@@ -32,10 +32,7 @@ class DataFrame {

bool delete_when_done;

size_t index;

DataFrame() : data(NULL), size(0), delete_when_done(false), index(0) {}

- virtual ~DataFrame() {

- if (delete_when_done)

- delete[] data;

- }

+ virtual ~DataFrame();

};

typedef std::list<DataFrame*> OutputList;

@@ -160,4 +157,3 @@ class SMConnection : public SMConnectionInterface,

} // namespace net

#endif // NET_TOOLS_FLIP_SERVER_SM_CONNECTION_H_

« no previous file with comments | « net/tools/flip_server/simple_buffer.cc ('k') | net/tools/flip_server/sm_connection.cc » ('j') | no next file with comments »