webkit/appcache/appcache_disk_cache.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/appcache/appcache_disk_cache.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/appcache/appcache_disk_cache.h

diff --git a/webkit/appcache/appcache_disk_cache.h b/webkit/appcache/appcache_disk_cache.h

index 17998130cf2e977d1552b4c1a964bae9090a1ecc..404da0598e8a7dbe50e7d1d29027382454ef9df9 100644

--- a/webkit/appcache/appcache_disk_cache.h

+++ b/webkit/appcache/appcache_disk_cache.h

@@ -57,7 +57,7 @@ class AppCacheDiskCache {

disk_cache::Backend* backend_ptr_; // Accessed directly.

private:

- ~CreateBackendCallback() {

+ virtual ~CreateBackendCallback() {

delete backend_ptr_;

}

};

« no previous file with comments | « skia/ext/vector_platform_device_skia.h ('k') | webkit/appcache/appcache_host.h » ('j') | no next file with comments »