Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: chrome/browser/sync/util/extensions_activity_monitor.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_UTIL_EXTENSIONS_ACTIVITY_MONITOR_H_ 5 #ifndef CHROME_BROWSER_SYNC_UTIL_EXTENSIONS_ACTIVITY_MONITOR_H_
6 #define CHROME_BROWSER_SYNC_UTIL_EXTENSIONS_ACTIVITY_MONITOR_H_ 6 #define CHROME_BROWSER_SYNC_UTIL_EXTENSIONS_ACTIVITY_MONITOR_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 10
(...skipping 28 matching lines...) Expand all
39 // How many times the extension successfully invoked a write 39 // How many times the extension successfully invoked a write
40 // operation through the bookmarks API since the last CommitMessage. 40 // operation through the bookmarks API since the last CommitMessage.
41 uint32 bookmark_write_count; 41 uint32 bookmark_write_count;
42 }; 42 };
43 43
44 typedef std::map<std::string, Record> Records; 44 typedef std::map<std::string, Record> Records;
45 45
46 // Creates an ExtensionsActivityMonitor to monitor extensions activities on 46 // Creates an ExtensionsActivityMonitor to monitor extensions activities on
47 // BrowserThread::UI. 47 // BrowserThread::UI.
48 ExtensionsActivityMonitor(); 48 ExtensionsActivityMonitor();
49 ~ExtensionsActivityMonitor(); 49 virtual ~ExtensionsActivityMonitor();
50 50
51 // Fills |buffer| with snapshot of current records in constant time by 51 // Fills |buffer| with snapshot of current records in constant time by
52 // swapping. This is done mutually exclusively w.r.t methods of this class. 52 // swapping. This is done mutually exclusively w.r.t methods of this class.
53 void GetAndClearRecords(Records* buffer); 53 void GetAndClearRecords(Records* buffer);
54 54
55 // Add |records| piece-wise (by extension id) to the set of active records. 55 // Add |records| piece-wise (by extension id) to the set of active records.
56 // This is done mutually exclusively w.r.t the methods of this class. 56 // This is done mutually exclusively w.r.t the methods of this class.
57 void PutRecords(const Records& records); 57 void PutRecords(const Records& records);
58 58
59 // NotificationObserver implementation. Called on |ui_loop_|. 59 // NotificationObserver implementation. Called on |ui_loop_|.
60 virtual void Observe(NotificationType type, 60 virtual void Observe(NotificationType type,
61 const NotificationSource& source, 61 const NotificationSource& source,
62 const NotificationDetails& details); 62 const NotificationDetails& details);
63 private: 63 private:
64 Records records_; 64 Records records_;
65 mutable base::Lock records_lock_; 65 mutable base::Lock records_lock_;
66 66
67 // Used only from UI loop. 67 // Used only from UI loop.
68 NotificationRegistrar registrar_; 68 NotificationRegistrar registrar_;
69 }; 69 };
70 70
71 } // namespace browser_sync 71 } // namespace browser_sync
72 72
73 #endif // CHROME_BROWSER_SYNC_UTIL_EXTENSIONS_ACTIVITY_MONITOR_H_ 73 #endif // CHROME_BROWSER_SYNC_UTIL_EXTENSIONS_ACTIVITY_MONITOR_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/notifier/chrome_system_resources.h ('k') | chrome/browser/tab_contents/render_view_context_menu_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698