Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: chrome/browser/autocomplete/search_provider.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file contains the Search autocomplete provider. This provider is 5 // This file contains the Search autocomplete provider. This provider is
6 // responsible for all non-keyword autocomplete entries that start with 6 // responsible for all non-keyword autocomplete entries that start with
7 // "Search <engine> for ...", including searching for the current input string, 7 // "Search <engine> for ...", including searching for the current input string,
8 // search history, and search suggestions. An instance of it gets created and 8 // search history, and search suggestions. An instance of it gets created and
9 // managed by the autocomplete controller. 9 // managed by the autocomplete controller.
10 // 10 //
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 const net::ResponseCookies& cookies, 75 const net::ResponseCookies& cookies,
76 const std::string& data); 76 const std::string& data);
77 77
78 // ID used in creating URLFetcher for default provider's suggest results. 78 // ID used in creating URLFetcher for default provider's suggest results.
79 static const int kDefaultProviderURLFetcherID; 79 static const int kDefaultProviderURLFetcherID;
80 80
81 // ID used in creating URLFetcher for keyword provider's suggest results. 81 // ID used in creating URLFetcher for keyword provider's suggest results.
82 static const int kKeywordProviderURLFetcherID; 82 static const int kKeywordProviderURLFetcherID;
83 83
84 private: 84 private:
85 ~SearchProvider(); 85 virtual ~SearchProvider();
86 86
87 // Manages the providers (TemplateURLs) used by SearchProvider. Two providers 87 // Manages the providers (TemplateURLs) used by SearchProvider. Two providers
88 // may be used: 88 // may be used:
89 // . The default provider. This corresponds to the user's default search 89 // . The default provider. This corresponds to the user's default search
90 // engine. This is always used, except for the rare case of no default 90 // engine. This is always used, except for the rare case of no default
91 // engine. 91 // engine.
92 // . The keyword provider. This is used if the user has typed in a keyword. 92 // . The keyword provider. This is used if the user has typed in a keyword.
93 class Providers { 93 class Providers {
94 public: 94 public:
95 Providers() : default_provider_(NULL), keyword_provider_(NULL) {} 95 Providers() : default_provider_(NULL), keyword_provider_(NULL) {}
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 // Has FinalizeInstantQuery been invoked since the last |Start|? 319 // Has FinalizeInstantQuery been invoked since the last |Start|?
320 bool instant_finalized_; 320 bool instant_finalized_;
321 321
322 // The |suggest_text| parameter passed to FinalizeInstantQuery. 322 // The |suggest_text| parameter passed to FinalizeInstantQuery.
323 string16 default_provider_suggest_text_; 323 string16 default_provider_suggest_text_;
324 324
325 DISALLOW_COPY_AND_ASSIGN(SearchProvider); 325 DISALLOW_COPY_AND_ASSIGN(SearchProvider);
326 }; 326 };
327 327
328 #endif // CHROME_BROWSER_AUTOCOMPLETE_SEARCH_PROVIDER_H_ 328 #endif // CHROME_BROWSER_AUTOCOMPLETE_SEARCH_PROVIDER_H_
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/history_quick_provider.h ('k') | chrome/browser/background_application_list_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698