Virtual destructors should have virtual keyword.

jingle/notifier/base/xmpp_connection.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A class that manages a connection to an XMPP server.
 
 #ifndef JINGLE_NOTIFIER_BASE_XMPP_CONNECTION_H_
 #define JINGLE_NOTIFIER_BASE_XMPP_CONNECTION_H_
 #pragma once
 
@@ skipping 56 matching lines @@
   //
   // TODO(akalin): Avoid the need for |pre_xmpp_auth|.
   XmppConnection(const buzz::XmppClientSettings& xmpp_client_settings,
                  const scoped_refptr<net::URLRequestContextGetter>&
                      request_context_getter,
                  Delegate* delegate, buzz::PreXmppAuth* pre_xmpp_auth);
 
   // Invalidates any weak pointers passed to the delegate by
   // OnConnect(), but does not trigger a call to the delegate's
   // OnError() function.
-  ~XmppConnection();
+  virtual ~XmppConnection();
 
  private:
   void OnStateChange(buzz::XmppEngine::State state);
   void OnInputLog(const char* data, int len);
   void OnOutputLog(const char* data, int len);
 
   void ClearClient();
 
   base::NonThreadSafe non_thread_safe_;
   scoped_ptr<TaskPump> task_pump_;
   base::WeakPtr<WeakXmppClient> weak_xmpp_client_;
   bool on_connect_called_;
   Delegate* delegate_;
 
   FRIEND_TEST(XmppConnectionTest, RaisedError);
   FRIEND_TEST(XmppConnectionTest, Connect);
   FRIEND_TEST(XmppConnectionTest, MultipleConnect);
   FRIEND_TEST(XmppConnectionTest, ConnectThenError);
 
   DISALLOW_COPY_AND_ASSIGN(XmppConnection);
 };
 
 }  // namespace notifier
 
 #endif  // JINGLE_NOTIFIER_BASE_XMPP_CONNECTION_H_