Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: chrome/browser/extensions/extension_test_api.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_test_api.h
diff --git a/chrome/browser/extensions/extension_test_api.h b/chrome/browser/extensions/extension_test_api.h
index 1a0baa0818ceeb3356b0f9fe060084e1898599f0..b3c113a8c78d967d914fbba73ed23c526ad49374 100644
--- a/chrome/browser/extensions/extension_test_api.h
+++ b/chrome/browser/extensions/extension_test_api.h
@@ -12,31 +12,31 @@
template <typename T> struct DefaultSingletonTraits;
class ExtensionTestPassFunction : public SyncExtensionFunction {
- ~ExtensionTestPassFunction();
+ virtual ~ExtensionTestPassFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("test.notifyPass")
};
class ExtensionTestFailFunction : public SyncExtensionFunction {
- ~ExtensionTestFailFunction();
+ virtual ~ExtensionTestFailFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("test.notifyFail")
};
class ExtensionTestLogFunction : public SyncExtensionFunction {
- ~ExtensionTestLogFunction();
+ virtual ~ExtensionTestLogFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("test.log")
};
class ExtensionTestQuotaResetFunction : public SyncExtensionFunction {
- ~ExtensionTestQuotaResetFunction();
+ virtual ~ExtensionTestQuotaResetFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("test.resetQuota")
};
class ExtensionTestCreateIncognitoTabFunction : public SyncExtensionFunction {
- ~ExtensionTestCreateIncognitoTabFunction();
+ virtual ~ExtensionTestCreateIncognitoTabFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("test.createIncognitoTab")
};
@@ -48,7 +48,7 @@ class ExtensionTestSendMessageFunction : public AsyncExtensionFunction {
void Reply(const std::string& message);
private:
- ~ExtensionTestSendMessageFunction();
+ virtual ~ExtensionTestSendMessageFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("test.sendMessage")
};
@@ -81,7 +81,7 @@ class ExtensionTestGetConfigFunction : public SyncExtensionFunction {
DISALLOW_COPY_AND_ASSIGN(TestConfigState);
};
- ~ExtensionTestGetConfigFunction();
+ virtual ~ExtensionTestGetConfigFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("test.getConfig")
};
« no previous file with comments | « chrome/browser/extensions/extension_tabs_module.h ('k') | chrome/browser/extensions/extension_test_message_listener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698