chrome/browser/net/passive_log_collector.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/passive_log_collector.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/passive_log_collector.h

diff --git a/chrome/browser/net/passive_log_collector.h b/chrome/browser/net/passive_log_collector.h

index 2e541f5ee664bb49cc9826a3a26de21b6b7f8c16..d2090319c5d4b42e15a5112afa2124273c7de090 100644

--- a/chrome/browser/net/passive_log_collector.h

+++ b/chrome/browser/net/passive_log_collector.h

@@ -90,7 +90,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserver {

class GlobalSourceTracker : public SourceTrackerInterface {

public:

GlobalSourceTracker();

- ~GlobalSourceTracker();

+ virtual ~GlobalSourceTracker();

// SourceTrackerInterface implementation:

virtual void OnAddEntry(const ChromeNetLog::Entry& entry);

@@ -343,7 +343,7 @@ class PassiveLogCollector : public ChromeNetLog::ThreadSafeObserver {

PassiveLogCollector();

- ~PassiveLogCollector();

+ virtual ~PassiveLogCollector();

// ThreadSafeObserver implementation:

virtual void OnAddEntry(net::NetLog::EventType type,