net/http/http_auth_handler_basic.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_basic.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_handler_basic.h

diff --git a/net/http/http_auth_handler_basic.h b/net/http/http_auth_handler_basic.h

index b98c7fde66bde0b174b4844c91bf70f3a6b654b1..5c747c930a75fabb86dba94f38a472ad2d23c753 100644

--- a/net/http/http_auth_handler_basic.h

+++ b/net/http/http_auth_handler_basic.h

@@ -45,7 +45,7 @@ class NET_TEST HttpAuthHandlerBasic : public HttpAuthHandler {

std::string* auth_token);

private:

- ~HttpAuthHandlerBasic() {}

+ virtual ~HttpAuthHandlerBasic() {}

bool ParseChallenge(HttpAuth::ChallengeTokenizer* challenge);

};

« no previous file with comments | « net/ftp/ftp_network_layer.h ('k') | net/http/http_auth_handler_digest.h » ('j') | no next file with comments »