Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: remoting/jingle_glue/iq_request.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « remoting/host/capturer_fake_ascii.h ('k') | remoting/jingle_glue/ssl_socket_adapter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_JINGLE_GLUE_IQ_REQUEST_H_ 5 #ifndef REMOTING_JINGLE_GLUE_IQ_REQUEST_H_
6 #define REMOTING_JINGLE_GLUE_IQ_REQUEST_H_ 6 #define REMOTING_JINGLE_GLUE_IQ_REQUEST_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 // 225 //
226 // This class is not threadsafe, and should only be used on the thread it is 226 // This class is not threadsafe, and should only be used on the thread it is
227 // created on. 227 // created on.
228 // 228 //
229 // TODO(ajwong): Move into its own file, and rename to something better since 229 // TODO(ajwong): Move into its own file, and rename to something better since
230 // this is not actually a Request. Maybe SessionEstablishmentConnector. 230 // this is not actually a Request. Maybe SessionEstablishmentConnector.
231 class SessionStartRequest : public sigslot::has_slots<> { 231 class SessionStartRequest : public sigslot::has_slots<> {
232 public: 232 public:
233 SessionStartRequest(JavascriptIqRequest* request, 233 SessionStartRequest(JavascriptIqRequest* request,
234 cricket::SessionManager* session_manager); 234 cricket::SessionManager* session_manager);
235 ~SessionStartRequest(); 235 virtual ~SessionStartRequest();
236 236
237 void Run(); 237 void Run();
238 238
239 private: 239 private:
240 void OnResponse(const buzz::XmlElement* stanza); 240 void OnResponse(const buzz::XmlElement* stanza);
241 241
242 void OnOutgoingMessage(cricket::SessionManager* manager, 242 void OnOutgoingMessage(cricket::SessionManager* manager,
243 const buzz::XmlElement* stanza); 243 const buzz::XmlElement* stanza);
244 244
245 scoped_ptr<JavascriptIqRequest> request_; 245 scoped_ptr<JavascriptIqRequest> request_;
246 cricket::SessionManager* session_manager_; 246 cricket::SessionManager* session_manager_;
247 247
248 DISALLOW_COPY_AND_ASSIGN(SessionStartRequest); 248 DISALLOW_COPY_AND_ASSIGN(SessionStartRequest);
249 }; 249 };
250 250
251 } // namespace remoting 251 } // namespace remoting
252 252
253 #endif // REMOTING_JINGLE_GLUE_IQ_REQUEST_H_ 253 #endif // REMOTING_JINGLE_GLUE_IQ_REQUEST_H_
OLDNEW
« no previous file with comments | « remoting/host/capturer_fake_ascii.h ('k') | remoting/jingle_glue/ssl_socket_adapter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698