Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: webkit/support/simple_database_system.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/quota/usage_tracker.h ('k') | webkit/tools/test_shell/layout_test_controller.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_SUPPORT_SIMPLE_DATABASE_SYSTEM_H_ 5 #ifndef WEBKIT_SUPPORT_SIMPLE_DATABASE_SYSTEM_H_
6 #define WEBKIT_SUPPORT_SIMPLE_DATABASE_SYSTEM_H_ 6 #define WEBKIT_SUPPORT_SIMPLE_DATABASE_SYSTEM_H_
7 7
8 #include "base/file_path.h" 8 #include "base/file_path.h"
9 #include "base/hash_tables.h" 9 #include "base/hash_tables.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 11 matching lines...) Expand all
22 class MessageLoopProxy; 22 class MessageLoopProxy;
23 class WaitableEvent; 23 class WaitableEvent;
24 } 24 }
25 25
26 class SimpleDatabaseSystem : public webkit_database::DatabaseTracker::Observer, 26 class SimpleDatabaseSystem : public webkit_database::DatabaseTracker::Observer,
27 public WebKit::WebDatabaseObserver { 27 public WebKit::WebDatabaseObserver {
28 public: 28 public:
29 static SimpleDatabaseSystem* GetInstance(); 29 static SimpleDatabaseSystem* GetInstance();
30 30
31 SimpleDatabaseSystem(); 31 SimpleDatabaseSystem();
32 ~SimpleDatabaseSystem(); 32 virtual ~SimpleDatabaseSystem();
33 33
34 // WebDatabaseObserver implementation, these are called on the script 34 // WebDatabaseObserver implementation, these are called on the script
35 // execution context thread on which the database is opened. This may be 35 // execution context thread on which the database is opened. This may be
36 // the main thread or background WebWorker threads. 36 // the main thread or background WebWorker threads.
37 virtual void databaseOpened(const WebKit::WebDatabase& database); 37 virtual void databaseOpened(const WebKit::WebDatabase& database);
38 virtual void databaseModified(const WebKit::WebDatabase& database); 38 virtual void databaseModified(const WebKit::WebDatabase& database);
39 virtual void databaseClosed(const WebKit::WebDatabase& database); 39 virtual void databaseClosed(const WebKit::WebDatabase& database);
40 40
41 // SQLite VFS related methods, these are called on webcore's 41 // SQLite VFS related methods, these are called on webcore's
42 // background database threads via the WebKitClient impl. 42 // background database threads via the WebKitClient impl.
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 94
95 // Data members to support waiting for all connections to be closed. 95 // Data members to support waiting for all connections to be closed.
96 scoped_refptr<webkit_database::DatabaseConnectionsWrapper> open_connections_; 96 scoped_refptr<webkit_database::DatabaseConnectionsWrapper> open_connections_;
97 97
98 static SimpleDatabaseSystem* instance_; 98 static SimpleDatabaseSystem* instance_;
99 }; 99 };
100 100
101 DISABLE_RUNNABLE_METHOD_REFCOUNT(SimpleDatabaseSystem); 101 DISABLE_RUNNABLE_METHOD_REFCOUNT(SimpleDatabaseSystem);
102 102
103 #endif // WEBKIT_SUPPORT_SIMPLE_DATABASE_SYSTEM_H_ 103 #endif // WEBKIT_SUPPORT_SIMPLE_DATABASE_SYSTEM_H_
OLDNEW
« no previous file with comments | « webkit/quota/usage_tracker.h ('k') | webkit/tools/test_shell/layout_test_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698