chrome/browser/tab_contents/thumbnail_generator.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/thumbnail_generator.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/thumbnail_generator.h

diff --git a/chrome/browser/tab_contents/thumbnail_generator.h b/chrome/browser/tab_contents/thumbnail_generator.h

index fb472934c1c6e405264a14c570dbfce35cdf00d6..c44a95279a63ca69a5ec87526ce2cc482c92db68 100644

--- a/chrome/browser/tab_contents/thumbnail_generator.h

+++ b/chrome/browser/tab_contents/thumbnail_generator.h

@@ -54,7 +54,7 @@ class ThumbnailGenerator : NotificationObserver {

// This class will do nothing until you call StartThumbnailing.

ThumbnailGenerator();

- ~ThumbnailGenerator();

+ virtual ~ThumbnailGenerator();

// Starts taking thumbnails of the given tab contents.

void StartThumbnailing(TabContents* tab_contents);