Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chrome/browser/net/load_timing_observer.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/net/chrome_net_log.h ('k') | chrome/browser/net/net_log_logger.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_LOAD_TIMING_OBSERVER_H_ 5 #ifndef CHROME_BROWSER_NET_LOAD_TIMING_OBSERVER_H_
6 #define CHROME_BROWSER_NET_LOAD_TIMING_OBSERVER_H_ 6 #define CHROME_BROWSER_NET_LOAD_TIMING_OBSERVER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/gtest_prod_util.h" 9 #include "base/gtest_prod_util.h"
10 #include "base/hash_tables.h" 10 #include "base/hash_tables.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 base::TimeTicks dns_start; 53 base::TimeTicks dns_start;
54 base::TimeTicks dns_end; 54 base::TimeTicks dns_end;
55 }; 55 };
56 56
57 struct SocketRecord { 57 struct SocketRecord {
58 base::TimeTicks ssl_start; 58 base::TimeTicks ssl_start;
59 base::TimeTicks ssl_end; 59 base::TimeTicks ssl_end;
60 }; 60 };
61 61
62 LoadTimingObserver(); 62 LoadTimingObserver();
63 ~LoadTimingObserver(); 63 virtual ~LoadTimingObserver();
64 64
65 URLRequestRecord* GetURLRequestRecord(uint32 source_id); 65 URLRequestRecord* GetURLRequestRecord(uint32 source_id);
66 66
67 // ThreadSafeObserver implementation: 67 // ThreadSafeObserver implementation:
68 virtual void OnAddEntry(net::NetLog::EventType type, 68 virtual void OnAddEntry(net::NetLog::EventType type,
69 const base::TimeTicks& time, 69 const base::TimeTicks& time,
70 const net::NetLog::Source& source, 70 const net::NetLog::Source& source,
71 net::NetLog::EventPhase phase, 71 net::NetLog::EventPhase phase,
72 net::NetLog::EventParameters* params); 72 net::NetLog::EventParameters* params);
73 73
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 HTTPStreamJobToRecordMap http_stream_job_to_record_; 117 HTTPStreamJobToRecordMap http_stream_job_to_record_;
118 ConnectJobToRecordMap connect_job_to_record_; 118 ConnectJobToRecordMap connect_job_to_record_;
119 SocketToRecordMap socket_to_record_; 119 SocketToRecordMap socket_to_record_;
120 uint32 last_connect_job_id_; 120 uint32 last_connect_job_id_;
121 ConnectJobRecord last_connect_job_record_; 121 ConnectJobRecord last_connect_job_record_;
122 122
123 DISALLOW_COPY_AND_ASSIGN(LoadTimingObserver); 123 DISALLOW_COPY_AND_ASSIGN(LoadTimingObserver);
124 }; 124 };
125 125
126 #endif // CHROME_BROWSER_NET_LOAD_TIMING_OBSERVER_H_ 126 #endif // CHROME_BROWSER_NET_LOAD_TIMING_OBSERVER_H_
OLDNEW
« no previous file with comments | « chrome/browser/net/chrome_net_log.h ('k') | chrome/browser/net/net_log_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698