Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2525)

Unified Diff: chrome/browser/extensions/extension_context_menu_api.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_context_menu_api.h
diff --git a/chrome/browser/extensions/extension_context_menu_api.h b/chrome/browser/extensions/extension_context_menu_api.h
index 5562bc70d5f2dabf5b4e26e3c570ed8f21c36072..a7b1694a74431c1c1355b0cb23d83eceec925b44 100644
--- a/chrome/browser/extensions/extension_context_menu_api.h
+++ b/chrome/browser/extensions/extension_context_menu_api.h
@@ -15,7 +15,7 @@ class ExtensionMenuItem;
class ExtensionContextMenuFunction : public SyncExtensionFunction {
public:
- ~ExtensionContextMenuFunction() {}
+ virtual ~ExtensionContextMenuFunction() {}
protected:
// Helper function to read and parse a list of menu item contexts.
@@ -60,25 +60,25 @@ class ExtensionContextMenuFunction : public SyncExtensionFunction {
};
class CreateContextMenuFunction : public ExtensionContextMenuFunction {
- ~CreateContextMenuFunction() {}
+ virtual ~CreateContextMenuFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.create")
};
class UpdateContextMenuFunction : public ExtensionContextMenuFunction {
- ~UpdateContextMenuFunction() {}
+ virtual ~UpdateContextMenuFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.update")
};
class RemoveContextMenuFunction : public ExtensionContextMenuFunction {
- ~RemoveContextMenuFunction() {}
+ virtual ~RemoveContextMenuFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.remove")
};
class RemoveAllContextMenusFunction : public ExtensionContextMenuFunction {
- ~RemoveAllContextMenusFunction() {}
+ virtual ~RemoveAllContextMenusFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.removeAll")
};
« no previous file with comments | « chrome/browser/extensions/extension_browser_event_router.h ('k') | chrome/browser/extensions/extension_debugger_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698