Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: content/browser/appcache/appcache_dispatcher_host.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/test_notification_tracker.h ('k') | content/browser/cert_store.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_DISPATCHER_HOST_H_ 5 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_DISPATCHER_HOST_H_
6 #define CONTENT_BROWSER_APPCACHE_APPCACHE_DISPATCHER_HOST_H_ 6 #define CONTENT_BROWSER_APPCACHE_APPCACHE_DISPATCHER_HOST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 11 matching lines...) Expand all
22 } // namespace content 22 } // namespace content
23 23
24 // Handles appcache related messages sent to the main browser process from 24 // Handles appcache related messages sent to the main browser process from
25 // its child processes. There is a distinct host for each child process. 25 // its child processes. There is a distinct host for each child process.
26 // Messages are handled on the IO thread. The BrowserRenderProcessHost and 26 // Messages are handled on the IO thread. The BrowserRenderProcessHost and
27 // WorkerProcessHost create an instance and delegates calls to it. 27 // WorkerProcessHost create an instance and delegates calls to it.
28 class AppCacheDispatcherHost : public BrowserMessageFilter { 28 class AppCacheDispatcherHost : public BrowserMessageFilter {
29 public: 29 public:
30 AppCacheDispatcherHost(const content::ResourceContext* resource_context, 30 AppCacheDispatcherHost(const content::ResourceContext* resource_context,
31 int process_id); 31 int process_id);
32 ~AppCacheDispatcherHost(); 32 virtual ~AppCacheDispatcherHost();
33 33
34 // BrowserIOMessageFilter implementation 34 // BrowserIOMessageFilter implementation
35 virtual void OnChannelConnected(int32 peer_pid); 35 virtual void OnChannelConnected(int32 peer_pid);
36 virtual bool OnMessageReceived(const IPC::Message& message, 36 virtual bool OnMessageReceived(const IPC::Message& message,
37 bool* message_was_ok); 37 bool* message_was_ok);
38 38
39 private: 39 private:
40 // BrowserMessageFilter override. 40 // BrowserMessageFilter override.
41 virtual void BadMessageReceived(); 41 virtual void BadMessageReceived();
42 42
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 scoped_ptr<appcache::SwapCacheCallback> swap_cache_callback_; 79 scoped_ptr<appcache::SwapCacheCallback> swap_cache_callback_;
80 scoped_ptr<IPC::Message> pending_reply_msg_; 80 scoped_ptr<IPC::Message> pending_reply_msg_;
81 81
82 // The corresponding ChildProcessHost object's id(). 82 // The corresponding ChildProcessHost object's id().
83 int process_id_; 83 int process_id_;
84 84
85 DISALLOW_COPY_AND_ASSIGN(AppCacheDispatcherHost); 85 DISALLOW_COPY_AND_ASSIGN(AppCacheDispatcherHost);
86 }; 86 };
87 87
88 #endif // CONTENT_BROWSER_APPCACHE_APPCACHE_DISPATCHER_HOST_H_ 88 #endif // CONTENT_BROWSER_APPCACHE_APPCACHE_DISPATCHER_HOST_H_
OLDNEW
« no previous file with comments | « chrome/test/test_notification_tracker.h ('k') | content/browser/cert_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698