Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: chrome/browser/plugin_data_remover_helper.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/plugin_data_remover.h ('k') | chrome/browser/plugin_observer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PLUGIN_DATA_REMOVER_HELPER_H_ 5 #ifndef CHROME_BROWSER_PLUGIN_DATA_REMOVER_HELPER_H_
6 #define CHROME_BROWSER_PLUGIN_DATA_REMOVER_HELPER_H_ 6 #define CHROME_BROWSER_PLUGIN_DATA_REMOVER_HELPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "chrome/browser/prefs/pref_member.h" 10 #include "chrome/browser/prefs/pref_member.h"
11 #include "content/common/notification_observer.h" 11 #include "content/common/notification_observer.h"
12 #include "content/common/notification_registrar.h" 12 #include "content/common/notification_registrar.h"
13 13
14 class Profile; 14 class Profile;
15 15
16 // Helper class modeled after BooleanPrefMember to (asynchronously) update 16 // Helper class modeled after BooleanPrefMember to (asynchronously) update
17 // the preference specifying whether clearing plug-in data is supported 17 // the preference specifying whether clearing plug-in data is supported
18 // by an installed plug-in. 18 // by an installed plug-in.
19 // It should only be used from the UI thread. The client has to make sure that 19 // It should only be used from the UI thread. The client has to make sure that
20 // the passed PrefService outlives this object. 20 // the passed PrefService outlives this object.
21 class PluginDataRemoverHelper : public NotificationObserver { 21 class PluginDataRemoverHelper : public NotificationObserver {
22 public: 22 public:
23 PluginDataRemoverHelper(); 23 PluginDataRemoverHelper();
24 ~PluginDataRemoverHelper(); 24 virtual ~PluginDataRemoverHelper();
25 25
26 // Binds this object to the |pref_name| preference in |prefs|, notifying 26 // Binds this object to the |pref_name| preference in |prefs|, notifying
27 // |observer| if the value changes. 27 // |observer| if the value changes.
28 // This fires off a request to the NPAPI::PluginList (via PluginDataRemover) 28 // This fires off a request to the NPAPI::PluginList (via PluginDataRemover)
29 // on the FILE thread to get the list of installed plug-ins. 29 // on the FILE thread to get the list of installed plug-ins.
30 void Init(const char* pref_name, 30 void Init(const char* pref_name,
31 PrefService* prefs, 31 PrefService* prefs,
32 NotificationObserver* observer); 32 NotificationObserver* observer);
33 33
34 bool GetValue() const { return pref_.GetValue(); } 34 bool GetValue() const { return pref_.GetValue(); }
35 35
36 // NotificationObserver methods: 36 // NotificationObserver methods:
37 virtual void Observe(NotificationType type, 37 virtual void Observe(NotificationType type,
38 const NotificationSource& source, 38 const NotificationSource& source,
39 const NotificationDetails& details); 39 const NotificationDetails& details);
40 40
41 private: 41 private:
42 class Internal; 42 class Internal;
43 43
44 BooleanPrefMember pref_; 44 BooleanPrefMember pref_;
45 NotificationRegistrar registrar_; 45 NotificationRegistrar registrar_;
46 scoped_refptr<Internal> internal_; 46 scoped_refptr<Internal> internal_;
47 47
48 DISALLOW_COPY_AND_ASSIGN(PluginDataRemoverHelper); 48 DISALLOW_COPY_AND_ASSIGN(PluginDataRemoverHelper);
49 }; 49 };
50 50
51 #endif // CHROME_BROWSER_PLUGIN_DATA_REMOVER_HELPER_H_ 51 #endif // CHROME_BROWSER_PLUGIN_DATA_REMOVER_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/plugin_data_remover.h ('k') | chrome/browser/plugin_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698