Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: net/disk_cache/file_lock.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/entry_impl.h ('k') | net/disk_cache/file_lock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/file_lock.h
diff --git a/net/disk_cache/file_lock.h b/net/disk_cache/file_lock.h
index 48f872ac6f914aae6d48b14d639ea73f6e558390..9823292816ae9d735375ac41f2274d7e05c746f1 100644
--- a/net/disk_cache/file_lock.h
+++ b/net/disk_cache/file_lock.h
@@ -31,9 +31,8 @@ namespace disk_cache {
class NET_TEST FileLock {
public:
explicit FileLock(BlockFileHeader* header);
- virtual ~FileLock() {
- Unlock();
- }
+ virtual ~FileLock();
+
// Virtual to make sure the compiler never inlines the calls.
virtual void Lock();
virtual void Unlock();
« no previous file with comments | « net/disk_cache/entry_impl.h ('k') | net/disk_cache/file_lock.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698