Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: chrome/browser/ui/cocoa/theme_install_bubble_view.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_THEME_INSTALL_BUBBLE_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_THEME_INSTALL_BUBBLE_VIEW_H_
6 #define CHROME_BROWSER_UI_COCOA_THEME_INSTALL_BUBBLE_VIEW_H_ 6 #define CHROME_BROWSER_UI_COCOA_THEME_INSTALL_BUBBLE_VIEW_H_
7 #pragma once 7 #pragma once
8 8
9 #include "content/common/notification_observer.h" 9 #include "content/common/notification_observer.h"
10 #include "content/common/notification_registrar.h" 10 #include "content/common/notification_registrar.h"
11 11
12 @class NSWindow; 12 @class NSWindow;
13 @class ThemeInstallBubbleViewCocoa; 13 @class ThemeInstallBubbleViewCocoa;
14 14
15 // ThemeInstallBubbleView is a view that provides a "Loading..." bubble in the 15 // ThemeInstallBubbleView is a view that provides a "Loading..." bubble in the
16 // center of a browser window for use when an extension or theme is loaded. 16 // center of a browser window for use when an extension or theme is loaded.
17 // (The Browser class only calls it to install itself into the currently active 17 // (The Browser class only calls it to install itself into the currently active
18 // browser window.) If an extension is being applied, the bubble goes away 18 // browser window.) If an extension is being applied, the bubble goes away
19 // immediately. If a theme is being applied, it disappears when the theme has 19 // immediately. If a theme is being applied, it disappears when the theme has
20 // been loaded. The purpose of this bubble is to warn the user that the browser 20 // been loaded. The purpose of this bubble is to warn the user that the browser
21 // may be unresponsive while the theme is being installed. 21 // may be unresponsive while the theme is being installed.
22 // 22 //
23 // Edge case: note that if one installs a theme in one window and then switches 23 // Edge case: note that if one installs a theme in one window and then switches
24 // rapidly to another window to install a theme there as well (in the short time 24 // rapidly to another window to install a theme there as well (in the short time
25 // between install begin and theme caching seizing the UI thread), the loading 25 // between install begin and theme caching seizing the UI thread), the loading
26 // bubble will only appear over the first window, as there is only ever one 26 // bubble will only appear over the first window, as there is only ever one
27 // instance of the bubble. 27 // instance of the bubble.
28 class ThemeInstallBubbleView : public NotificationObserver { 28 class ThemeInstallBubbleView : public NotificationObserver {
29 public: 29 public:
30 ~ThemeInstallBubbleView(); 30 virtual ~ThemeInstallBubbleView();
31 31
32 // NotificationObserver 32 // NotificationObserver
33 virtual void Observe(NotificationType type, 33 virtual void Observe(NotificationType type,
34 const NotificationSource& source, 34 const NotificationSource& source,
35 const NotificationDetails& details); 35 const NotificationDetails& details);
36 36
37 // Show the loading bubble. 37 // Show the loading bubble.
38 static void Show(NSWindow* window); 38 static void Show(NSWindow* window);
39 39
40 private: 40 private:
(...skipping 12 matching lines...) Expand all
53 ThemeInstallBubbleViewCocoa* cocoa_view_; 53 ThemeInstallBubbleViewCocoa* cocoa_view_;
54 54
55 // Multiple loads can be started at once. Only show one bubble, and keep 55 // Multiple loads can be started at once. Only show one bubble, and keep
56 // track of number of loads happening. Close bubble when num_loads < 1. 56 // track of number of loads happening. Close bubble when num_loads < 1.
57 int num_loads_extant_; 57 int num_loads_extant_;
58 58
59 DISALLOW_COPY_AND_ASSIGN(ThemeInstallBubbleView); 59 DISALLOW_COPY_AND_ASSIGN(ThemeInstallBubbleView);
60 }; 60 };
61 61
62 #endif // CHROME_BROWSER_UI_COCOA_THEME_INSTALL_BUBBLE_VIEW_H_ 62 #endif // CHROME_BROWSER_UI_COCOA_THEME_INSTALL_BUBBLE_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.h ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698