Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: chrome/browser/net/chrome_net_log.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.h ('k') | chrome/browser/net/load_timing_observer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_CHROME_NET_LOG_H_ 5 #ifndef CHROME_BROWSER_NET_CHROME_NET_LOG_H_
6 #define CHROME_BROWSER_NET_CHROME_NET_LOG_H_ 6 #define CHROME_BROWSER_NET_CHROME_NET_LOG_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 // AddObserver and RemoveObserver methods. 97 // AddObserver and RemoveObserver methods.
98 ChromeNetLog* net_log_; 98 ChromeNetLog* net_log_;
99 99
100 private: 100 private:
101 friend class ChromeNetLog; 101 friend class ChromeNetLog;
102 LogLevel log_level_; 102 LogLevel log_level_;
103 DISALLOW_COPY_AND_ASSIGN(ThreadSafeObserver); 103 DISALLOW_COPY_AND_ASSIGN(ThreadSafeObserver);
104 }; 104 };
105 105
106 ChromeNetLog(); 106 ChromeNetLog();
107 ~ChromeNetLog(); 107 virtual ~ChromeNetLog();
108 108
109 // NetLog implementation: 109 // NetLog implementation:
110 virtual void AddEntry(EventType type, 110 virtual void AddEntry(EventType type,
111 const base::TimeTicks& time, 111 const base::TimeTicks& time,
112 const Source& source, 112 const Source& source,
113 EventPhase phase, 113 EventPhase phase,
114 EventParameters* params); 114 EventParameters* params);
115 virtual uint32 NextID(); 115 virtual uint32 NextID();
116 virtual LogLevel GetLogLevel() const; 116 virtual LogLevel GetLogLevel() const;
117 117
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 scoped_ptr<LoadTimingObserver> load_timing_observer_; 160 scoped_ptr<LoadTimingObserver> load_timing_observer_;
161 scoped_ptr<NetLogLogger> net_log_logger_; 161 scoped_ptr<NetLogLogger> net_log_logger_;
162 162
163 // |lock_| must be acquired whenever reading or writing to this. 163 // |lock_| must be acquired whenever reading or writing to this.
164 ObserverList<ThreadSafeObserver, true> observers_; 164 ObserverList<ThreadSafeObserver, true> observers_;
165 165
166 DISALLOW_COPY_AND_ASSIGN(ChromeNetLog); 166 DISALLOW_COPY_AND_ASSIGN(ChromeNetLog);
167 }; 167 };
168 168
169 #endif // CHROME_BROWSER_NET_CHROME_NET_LOG_H_ 169 #endif // CHROME_BROWSER_NET_CHROME_NET_LOG_H_
OLDNEW
« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.h ('k') | chrome/browser/net/load_timing_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698