Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: content/browser/resolve_proxy_msg_helper.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RESOLVE_PROXY_MSG_HELPER_H_ 5 #ifndef CONTENT_BROWSER_RESOLVE_PROXY_MSG_HELPER_H_
6 #define CONTENT_BROWSER_RESOLVE_PROXY_MSG_HELPER_H_ 6 #define CONTENT_BROWSER_RESOLVE_PROXY_MSG_HELPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <deque> 9 #include <deque>
10 #include <string> 10 #include <string>
(...skipping 15 matching lines...) Expand all
26 // 26 //
27 // This object is expected to live on the IO thread. 27 // This object is expected to live on the IO thread.
28 class ResolveProxyMsgHelper : public BrowserMessageFilter { 28 class ResolveProxyMsgHelper : public BrowserMessageFilter {
29 public: 29 public:
30 // If |proxy_service| is NULL, then the main profile's proxy service will 30 // If |proxy_service| is NULL, then the main profile's proxy service will
31 // be used. 31 // be used.
32 explicit ResolveProxyMsgHelper(net::ProxyService* proxy_service); 32 explicit ResolveProxyMsgHelper(net::ProxyService* proxy_service);
33 33
34 // Destruction cancels the current outstanding request, and clears the 34 // Destruction cancels the current outstanding request, and clears the
35 // pending queue. 35 // pending queue.
36 ~ResolveProxyMsgHelper(); 36 virtual ~ResolveProxyMsgHelper();
37 37
38 // BrowserMessageFilter implementation 38 // BrowserMessageFilter implementation
39 virtual bool OnMessageReceived(const IPC::Message& message, 39 virtual bool OnMessageReceived(const IPC::Message& message,
40 bool* message_was_ok); 40 bool* message_was_ok);
41 41
42 void OnResolveProxy(const GURL& url, IPC::Message* reply_msg); 42 void OnResolveProxy(const GURL& url, IPC::Message* reply_msg);
43 43
44 private: 44 private:
45 // Callback for the ProxyService (bound to |callback_|). 45 // Callback for the ProxyService (bound to |callback_|).
46 void OnResolveProxyCompleted(int result); 46 void OnResolveProxyCompleted(int result);
(...skipping 29 matching lines...) Expand all
76 // FIFO queue of pending requests. The first entry is always the current one. 76 // FIFO queue of pending requests. The first entry is always the current one.
77 typedef std::deque<PendingRequest> PendingRequestList; 77 typedef std::deque<PendingRequest> PendingRequestList;
78 PendingRequestList pending_requests_; 78 PendingRequestList pending_requests_;
79 79
80 // Specified by unit-tests, to use this proxy service in place of the 80 // Specified by unit-tests, to use this proxy service in place of the
81 // global one. 81 // global one.
82 net::ProxyService* proxy_service_override_; 82 net::ProxyService* proxy_service_override_;
83 }; 83 };
84 84
85 #endif // CONTENT_BROWSER_RESOLVE_PROXY_MSG_HELPER_H_ 85 #endif // CONTENT_BROWSER_RESOLVE_PROXY_MSG_HELPER_H_
OLDNEW
« no previous file with comments | « content/browser/renderer_host/sync_resource_handler.h ('k') | content/browser/speech/speech_recognizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698