Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5002)

Unified Diff: chrome/browser/extensions/extension_debugger_api.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_debugger_api.h
diff --git a/chrome/browser/extensions/extension_debugger_api.h b/chrome/browser/extensions/extension_debugger_api.h
index 0974b1c25c21f7ec7944f25b7a0074c30b367376..5fd9d008cc3cc79b8497f7b8e5d2bf17a328a43a 100644
--- a/chrome/browser/extensions/extension_debugger_api.h
+++ b/chrome/browser/extensions/extension_debugger_api.h
@@ -34,7 +34,7 @@ class DebuggerFunction : public AsyncExtensionFunction {
class AttachDebuggerFunction : public DebuggerFunction {
public:
AttachDebuggerFunction();
- ~AttachDebuggerFunction();
+ virtual ~AttachDebuggerFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("experimental.debugger.attach")
};
@@ -43,7 +43,7 @@ class AttachDebuggerFunction : public DebuggerFunction {
class DetachDebuggerFunction : public DebuggerFunction {
public:
DetachDebuggerFunction();
- ~DetachDebuggerFunction();
+ virtual ~DetachDebuggerFunction();
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("experimental.debugger.detach")
};
@@ -52,7 +52,7 @@ class DetachDebuggerFunction : public DebuggerFunction {
class SendRequestDebuggerFunction : public DebuggerFunction {
public:
SendRequestDebuggerFunction();
- ~SendRequestDebuggerFunction();
+ virtual ~SendRequestDebuggerFunction();
virtual bool RunImpl();
void SendResponseBody(DictionaryValue* dictionary);
« no previous file with comments | « chrome/browser/extensions/extension_context_menu_api.h ('k') | chrome/browser/extensions/extension_event_router.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698