Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: net/socket/ssl_client_socket_nss.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/socket/ssl_client_socket_mac.h ('k') | net/socket/tcp_server_socket_libevent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_ 5 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_
6 #define NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_ 6 #define NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <certt.h> 9 #include <certt.h>
10 #include <keyt.h> 10 #include <keyt.h>
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 // in the server's certificate during the SSL handshake. If SSL client 46 // in the server's certificate during the SSL handshake. If SSL client
47 // authentication is requested, the host_and_port field of SSLCertRequestInfo 47 // authentication is requested, the host_and_port field of SSLCertRequestInfo
48 // will be populated with |host_and_port|. |ssl_config| specifies 48 // will be populated with |host_and_port|. |ssl_config| specifies
49 // the SSL settings. 49 // the SSL settings.
50 SSLClientSocketNSS(ClientSocketHandle* transport_socket, 50 SSLClientSocketNSS(ClientSocketHandle* transport_socket,
51 const HostPortPair& host_and_port, 51 const HostPortPair& host_and_port,
52 const SSLConfig& ssl_config, 52 const SSLConfig& ssl_config,
53 SSLHostInfo* ssl_host_info, 53 SSLHostInfo* ssl_host_info,
54 CertVerifier* cert_verifier, 54 CertVerifier* cert_verifier,
55 DnsCertProvenanceChecker* dnsrr_resolver); 55 DnsCertProvenanceChecker* dnsrr_resolver);
56 ~SSLClientSocketNSS(); 56 virtual ~SSLClientSocketNSS();
57 57
58 // For tests 58 // For tests
59 static void ClearSessionCache(); 59 static void ClearSessionCache();
60 60
61 // SSLClientSocket methods: 61 // SSLClientSocket methods:
62 virtual void GetSSLInfo(SSLInfo* ssl_info); 62 virtual void GetSSLInfo(SSLInfo* ssl_info);
63 virtual void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info); 63 virtual void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info);
64 virtual NextProtoStatus GetNextProto(std::string* proto); 64 virtual NextProtoStatus GetNextProto(std::string* proto);
65 virtual void UseDNSSEC(DNSSECProvider* provider); 65 virtual void UseDNSSEC(DNSSECProvider* provider);
66 66
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 // Added the following code Debugging in release mode. 254 // Added the following code Debugging in release mode.
255 mutable base::Lock lock_; 255 mutable base::Lock lock_;
256 // This is mutable so that CalledOnValidThread can set it. 256 // This is mutable so that CalledOnValidThread can set it.
257 // It's guarded by |lock_|. 257 // It's guarded by |lock_|.
258 mutable base::PlatformThreadId valid_thread_id_; 258 mutable base::PlatformThreadId valid_thread_id_;
259 }; 259 };
260 260
261 } // namespace net 261 } // namespace net
262 262
263 #endif // NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_ 263 #endif // NET_SOCKET_SSL_CLIENT_SOCKET_NSS_H_
OLDNEW
« no previous file with comments | « net/socket/ssl_client_socket_mac.h ('k') | net/socket/tcp_server_socket_libevent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698