Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: chrome/service/cloud_print/printer_job_handler.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_ 5 #ifndef CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_
6 #define CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_ 6 #define CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <list> 9 #include <list>
10 #include <string> 10 #include <string>
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 std::string caps_hash; 106 std::string caps_hash;
107 std::string tags_hash; 107 std::string tags_hash;
108 }; 108 };
109 109
110 // Begin public interface 110 // Begin public interface
111 PrinterJobHandler(const printing::PrinterBasicInfo& printer_info, 111 PrinterJobHandler(const printing::PrinterBasicInfo& printer_info,
112 const PrinterInfoFromCloud& printer_info_from_server, 112 const PrinterInfoFromCloud& printer_info_from_server,
113 const GURL& cloud_print_server_url, 113 const GURL& cloud_print_server_url,
114 cloud_print::PrintSystem* print_system, 114 cloud_print::PrintSystem* print_system,
115 Delegate* delegate); 115 Delegate* delegate);
116 ~PrinterJobHandler(); 116 virtual ~PrinterJobHandler();
117 bool Initialize(); 117 bool Initialize();
118 // Requests a job check. |reason| is the reason for fetching the job. Used 118 // Requests a job check. |reason| is the reason for fetching the job. Used
119 // for logging and diagnostc purposes. 119 // for logging and diagnostc purposes.
120 void CheckForJobs(const std::string& reason); 120 void CheckForJobs(const std::string& reason);
121 // Shutdown everything (the process is exiting). 121 // Shutdown everything (the process is exiting).
122 void Shutdown(); 122 void Shutdown();
123 base::TimeTicks last_job_fetch_time() const { return last_job_fetch_time_; } 123 base::TimeTicks last_job_fetch_time() const { return last_job_fetch_time_; }
124 // End public interface 124 // End public interface
125 125
126 // Begin Delegate implementations 126 // Begin Delegate implementations
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 DISALLOW_COPY_AND_ASSIGN(PrinterJobHandler); 301 DISALLOW_COPY_AND_ASSIGN(PrinterJobHandler);
302 }; 302 };
303 303
304 // This typedef is to workaround the issue with certain versions of 304 // This typedef is to workaround the issue with certain versions of
305 // Visual Studio where it gets confused between multiple Delegate 305 // Visual Studio where it gets confused between multiple Delegate
306 // classes and gives a C2500 error. (I saw this error on the try bots - 306 // classes and gives a C2500 error. (I saw this error on the try bots -
307 // the workaround was not needed for my machine). 307 // the workaround was not needed for my machine).
308 typedef PrinterJobHandler::Delegate PrinterJobHandlerDelegate; 308 typedef PrinterJobHandler::Delegate PrinterJobHandlerDelegate;
309 309
310 #endif // CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_ 310 #endif // CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_
OLDNEW
« no previous file with comments | « chrome/renderer/spellchecker/spellcheck.h ('k') | chrome/service/gaia/service_gaia_authenticator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698