Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Side by Side Diff: chrome/browser/tab_contents/render_view_context_menu_gtk.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TAB_CONTENTS_RENDER_VIEW_CONTEXT_MENU_GTK_H_ 5 #ifndef CHROME_BROWSER_TAB_CONTENTS_RENDER_VIEW_CONTEXT_MENU_GTK_H_
6 #define CHROME_BROWSER_TAB_CONTENTS_RENDER_VIEW_CONTEXT_MENU_GTK_H_ 6 #define CHROME_BROWSER_TAB_CONTENTS_RENDER_VIEW_CONTEXT_MENU_GTK_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "chrome/browser/tab_contents/render_view_context_menu.h" 10 #include "chrome/browser/tab_contents/render_view_context_menu.h"
11 #include "chrome/browser/ui/gtk/menu_gtk.h" 11 #include "chrome/browser/ui/gtk/menu_gtk.h"
12 #include "ui/gfx/point.h" 12 #include "ui/gfx/point.h"
13 13
14 struct ContextMenuParams; 14 struct ContextMenuParams;
15 15
16 class RenderViewContextMenuGtk : public RenderViewContextMenu, 16 class RenderViewContextMenuGtk : public RenderViewContextMenu,
17 public MenuGtk::Delegate { 17 public MenuGtk::Delegate {
18 public: 18 public:
19 RenderViewContextMenuGtk(TabContents* web_contents, 19 RenderViewContextMenuGtk(TabContents* web_contents,
20 const ContextMenuParams& params, 20 const ContextMenuParams& params,
21 uint32_t triggering_event_time); 21 uint32_t triggering_event_time);
22 22
23 ~RenderViewContextMenuGtk(); 23 virtual ~RenderViewContextMenuGtk();
24 24
25 // Show the menu at the given location. 25 // Show the menu at the given location.
26 void Popup(const gfx::Point& point); 26 void Popup(const gfx::Point& point);
27 27
28 // Menu::Delegate implementation --------------------------------------------- 28 // Menu::Delegate implementation ---------------------------------------------
29 virtual bool AlwaysShowIconForCmd(int command_id) const; 29 virtual bool AlwaysShowIconForCmd(int command_id) const;
30 30
31 protected: 31 protected:
32 // RenderViewContextMenu implementation -------------------------------------- 32 // RenderViewContextMenu implementation --------------------------------------
33 virtual void PlatformInit(); 33 virtual void PlatformInit();
34 // TODO(port): implement. 34 // TODO(port): implement.
35 virtual bool GetAcceleratorForCommandId( 35 virtual bool GetAcceleratorForCommandId(
36 int command_id, 36 int command_id,
37 ui::Accelerator* accelerator); 37 ui::Accelerator* accelerator);
38 38
39 private: 39 private:
40 scoped_ptr<MenuGtk> menu_gtk_; 40 scoped_ptr<MenuGtk> menu_gtk_;
41 uint32_t triggering_event_time_; 41 uint32_t triggering_event_time_;
42 }; 42 };
43 43
44 #endif // CHROME_BROWSER_TAB_CONTENTS_RENDER_VIEW_CONTEXT_MENU_GTK_H_ 44 #endif // CHROME_BROWSER_TAB_CONTENTS_RENDER_VIEW_CONTEXT_MENU_GTK_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/util/extensions_activity_monitor.h ('k') | chrome/browser/tab_contents/thumbnail_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698