Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: chrome/service/service_process.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_SERVICE_SERVICE_PROCESS_H_ 5 #ifndef CHROME_SERVICE_SERVICE_PROCESS_H_
6 #define CHROME_SERVICE_SERVICE_PROCESS_H_ 6 #define CHROME_SERVICE_SERVICE_PROCESS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 14 matching lines...) Expand all
25 class NetworkChangeNotifier; 25 class NetworkChangeNotifier;
26 } 26 }
27 27
28 class CommandLine; 28 class CommandLine;
29 29
30 // The ServiceProcess does not inherit from ChildProcess because this 30 // The ServiceProcess does not inherit from ChildProcess because this
31 // process can live independently of the browser process. 31 // process can live independently of the browser process.
32 class ServiceProcess : public CloudPrintProxy::Client { 32 class ServiceProcess : public CloudPrintProxy::Client {
33 public: 33 public:
34 ServiceProcess(); 34 ServiceProcess();
35 ~ServiceProcess(); 35 virtual ~ServiceProcess();
36 36
37 // Initialize the ServiceProcess with the message loop that it should run on. 37 // Initialize the ServiceProcess with the message loop that it should run on.
38 // ServiceProcess takes ownership of |state|. 38 // ServiceProcess takes ownership of |state|.
39 bool Initialize(MessageLoopForUI* message_loop, 39 bool Initialize(MessageLoopForUI* message_loop,
40 const CommandLine& command_line, 40 const CommandLine& command_line,
41 ServiceProcessState* state); 41 ServiceProcessState* state);
42 bool Teardown(); 42 bool Teardown();
43 // TODO(sanjeevr): Change various parts of the code such as 43 // TODO(sanjeevr): Change various parts of the code such as
44 // net::ProxyService::CreateSystemProxyConfigService to take in 44 // net::ProxyService::CreateSystemProxyConfigService to take in
45 // MessageLoopProxy* instead of MessageLoop*. When we have done that, we can 45 // MessageLoopProxy* instead of MessageLoop*. When we have done that, we can
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 DISALLOW_COPY_AND_ASSIGN(ServiceProcess); 129 DISALLOW_COPY_AND_ASSIGN(ServiceProcess);
130 }; 130 };
131 131
132 // Disable refcounting for runnable method because it is really not needed 132 // Disable refcounting for runnable method because it is really not needed
133 // when we post tasks on the main message loop. 133 // when we post tasks on the main message loop.
134 DISABLE_RUNNABLE_METHOD_REFCOUNT(ServiceProcess); 134 DISABLE_RUNNABLE_METHOD_REFCOUNT(ServiceProcess);
135 135
136 extern ServiceProcess* g_service_process; 136 extern ServiceProcess* g_service_process;
137 137
138 #endif // CHROME_SERVICE_SERVICE_PROCESS_H_ 138 #endif // CHROME_SERVICE_SERVICE_PROCESS_H_
OLDNEW
« no previous file with comments | « chrome/service/gaia/service_gaia_authenticator.h ('k') | chrome/test/live_sync/live_autofill_sync_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698