net/tools/flip_server/acceptor_thread.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/flip_server/acceptor_thread.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/flip_server/acceptor_thread.h

diff --git a/net/tools/flip_server/acceptor_thread.h b/net/tools/flip_server/acceptor_thread.h

index 8a30532b3aeccc6cf2f9e6f97a7f91f733e03d15..b378e4d1272cdb9f5080f8ea7df373091ba5cff0 100644

--- a/net/tools/flip_server/acceptor_thread.h

+++ b/net/tools/flip_server/acceptor_thread.h

@@ -46,7 +46,7 @@ class SMAcceptorThread : public base::SimpleThread,

public SMConnectionPoolInterface {

public:

SMAcceptorThread(FlipAcceptor *acceptor, MemoryCache* memory_cache);

- ~SMAcceptorThread();

+ virtual ~SMAcceptorThread();

// EpollCallbackInteface interface

virtual void OnRegistration(EpollServer* eps, int fd, int event_mask) {}

@@ -92,4 +92,3 @@ class SMAcceptorThread : public base::SimpleThread,

} // namespace net

#endif // NET_TOOLS_FLIP_SERVER_ACCEPTOR_THREAD_H_

« no previous file with comments | « net/socket_stream/socket_stream.h ('k') | net/tools/flip_server/simple_buffer.h » ('j') | no next file with comments »