Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: chrome/browser/tabs/tab_finder.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TABS_TAB_FINDER_H_ 5 #ifndef CHROME_BROWSER_TABS_TAB_FINDER_H_
6 #define CHROME_BROWSER_TABS_TAB_FINDER_H_ 6 #define CHROME_BROWSER_TABS_TAB_FINDER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 private: 49 private:
50 friend struct DefaultSingletonTraits<TabFinder>; 50 friend struct DefaultSingletonTraits<TabFinder>;
51 51
52 class TabContentsObserverImpl; 52 class TabContentsObserverImpl;
53 53
54 typedef std::map<TabContents*, GURL> TabContentsToURLMap; 54 typedef std::map<TabContents*, GURL> TabContentsToURLMap;
55 typedef std::set<TabContentsObserverImpl*> TabContentsObservers; 55 typedef std::set<TabContentsObserverImpl*> TabContentsObservers;
56 56
57 TabFinder(); 57 TabFinder();
58 ~TabFinder(); 58 virtual ~TabFinder();
59 59
60 void Init(); 60 void Init();
61 61
62 // Forwarded from TabContentsObserverImpl. 62 // Forwarded from TabContentsObserverImpl.
63 void DidNavigateAnyFramePostCommit( 63 void DidNavigateAnyFramePostCommit(
64 TabContents* source, 64 TabContents* source,
65 const NavigationController::LoadCommittedDetails& details, 65 const NavigationController::LoadCommittedDetails& details,
66 const ViewHostMsg_FrameNavigate_Params& params); 66 const ViewHostMsg_FrameNavigate_Params& params);
67 67
68 // Returns true if the tab's current url is |url|, or the start of the 68 // Returns true if the tab's current url is |url|, or the start of the
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 CancelableRequestConsumerTSimple<TabContents*> callback_consumer_; 102 CancelableRequestConsumerTSimple<TabContents*> callback_consumer_;
103 103
104 NotificationRegistrar registrar_; 104 NotificationRegistrar registrar_;
105 105
106 TabContentsObservers tab_contents_observers_; 106 TabContentsObservers tab_contents_observers_;
107 107
108 DISALLOW_COPY_AND_ASSIGN(TabFinder); 108 DISALLOW_COPY_AND_ASSIGN(TabFinder);
109 }; 109 };
110 110
111 #endif // CHROME_BROWSER_TABS_TAB_FINDER_H_ 111 #endif // CHROME_BROWSER_TABS_TAB_FINDER_H_
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/thumbnail_generator.h ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698