Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: chrome/browser/debugger/inspectable_tab_proxy.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEBUGGER_INSPECTABLE_TAB_PROXY_H_ 5 #ifndef CHROME_BROWSER_DEBUGGER_INSPECTABLE_TAB_PROXY_H_
6 #define CHROME_BROWSER_DEBUGGER_INSPECTABLE_TAB_PROXY_H_ 6 #define CHROME_BROWSER_DEBUGGER_INSPECTABLE_TAB_PROXY_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 59
60 // An internal implementation of DevToolsClientHost that delegates 60 // An internal implementation of DevToolsClientHost that delegates
61 // messages sent for DevToolsClient to a DebuggerShell instance. 61 // messages sent for DevToolsClient to a DebuggerShell instance.
62 class DevToolsClientHostImpl : public DevToolsClientHost { 62 class DevToolsClientHostImpl : public DevToolsClientHost {
63 public: 63 public:
64 DevToolsClientHostImpl( 64 DevToolsClientHostImpl(
65 int32 id, 65 int32 id,
66 DebuggerRemoteService* service, 66 DebuggerRemoteService* service,
67 InspectableTabProxy::IdToClientHostMap* map); 67 InspectableTabProxy::IdToClientHostMap* map);
68 ~DevToolsClientHostImpl(); 68 virtual ~DevToolsClientHostImpl();
69 69
70 DebuggerRemoteService* debugger_remote_service() { 70 DebuggerRemoteService* debugger_remote_service() {
71 return service_; 71 return service_;
72 } 72 }
73 73
74 void Close(); 74 void Close();
75 75
76 // DevToolsClientHost interface 76 // DevToolsClientHost interface
77 virtual void InspectedTabClosing(); 77 virtual void InspectedTabClosing();
78 virtual void SendMessageToClient(const IPC::Message& msg); 78 virtual void SendMessageToClient(const IPC::Message& msg);
79 virtual void TabReplaced(TabContentsWrapper* new_tab); 79 virtual void TabReplaced(TabContentsWrapper* new_tab);
80 80
81 private: 81 private:
82 // Message handling routines 82 // Message handling routines
83 void OnDebuggerOutput(const std::string& msg); 83 void OnDebuggerOutput(const std::string& msg);
84 virtual void FrameNavigating(const std::string& url); 84 virtual void FrameNavigating(const std::string& url);
85 void TabClosed(); 85 void TabClosed();
86 86
87 int32 id_; 87 int32 id_;
88 DebuggerRemoteService* service_; 88 DebuggerRemoteService* service_;
89 InspectableTabProxy::IdToClientHostMap* map_; 89 InspectableTabProxy::IdToClientHostMap* map_;
90 }; 90 };
91 91
92 #endif // CHROME_BROWSER_DEBUGGER_INSPECTABLE_TAB_PROXY_H_ 92 #endif // CHROME_BROWSER_DEBUGGER_INSPECTABLE_TAB_PROXY_H_
OLDNEW
« no previous file with comments | « chrome/browser/debugger/devtools_netlog_observer.h ('k') | chrome/browser/download/download_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698