Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: net/disk_cache/mem_entry_impl.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/disk_cache/mem_backend_impl.h ('k') | net/disk_cache/stats_histogram.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_DISK_CACHE_MEM_ENTRY_IMPL_H_ 5 #ifndef NET_DISK_CACHE_MEM_ENTRY_IMPL_H_
6 #define NET_DISK_CACHE_MEM_ENTRY_IMPL_H_ 6 #define NET_DISK_CACHE_MEM_ENTRY_IMPL_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/hash_tables.h" 9 #include "base/hash_tables.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 virtual void CancelSparseIO() {} 113 virtual void CancelSparseIO() {}
114 virtual int ReadyForSparseIO(net::CompletionCallback* completion_callback); 114 virtual int ReadyForSparseIO(net::CompletionCallback* completion_callback);
115 115
116 private: 116 private:
117 typedef base::hash_map<int, MemEntryImpl*> EntryMap; 117 typedef base::hash_map<int, MemEntryImpl*> EntryMap;
118 118
119 enum { 119 enum {
120 NUM_STREAMS = 3 120 NUM_STREAMS = 3
121 }; 121 };
122 122
123 ~MemEntryImpl(); 123 virtual ~MemEntryImpl();
124 124
125 // Do all the work for corresponding public functions. Implemented as 125 // Do all the work for corresponding public functions. Implemented as
126 // separate functions to make logging of results simpler. 126 // separate functions to make logging of results simpler.
127 int InternalReadData(int index, int offset, net::IOBuffer* buf, int buf_len); 127 int InternalReadData(int index, int offset, net::IOBuffer* buf, int buf_len);
128 int InternalWriteData(int index, int offset, net::IOBuffer* buf, int buf_len, 128 int InternalWriteData(int index, int offset, net::IOBuffer* buf, int buf_len,
129 bool truncate); 129 bool truncate);
130 int InternalReadSparseData(int64 offset, net::IOBuffer* buf, int buf_len); 130 int InternalReadSparseData(int64 offset, net::IOBuffer* buf, int buf_len);
131 int InternalWriteSparseData(int64 offset, net::IOBuffer* buf, int buf_len); 131 int InternalWriteSparseData(int64 offset, net::IOBuffer* buf, int buf_len);
132 132
133 // Old Entry interface. 133 // Old Entry interface.
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 bool doomed_; // True if this entry was removed from the cache. 181 bool doomed_; // True if this entry was removed from the cache.
182 182
183 net::BoundNetLog net_log_; 183 net::BoundNetLog net_log_;
184 184
185 DISALLOW_COPY_AND_ASSIGN(MemEntryImpl); 185 DISALLOW_COPY_AND_ASSIGN(MemEntryImpl);
186 }; 186 };
187 187
188 } // namespace disk_cache 188 } // namespace disk_cache
189 189
190 #endif // NET_DISK_CACHE_MEM_ENTRY_IMPL_H_ 190 #endif // NET_DISK_CACHE_MEM_ENTRY_IMPL_H_
OLDNEW
« no previous file with comments | « net/disk_cache/mem_backend_impl.h ('k') | net/disk_cache/stats_histogram.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698