Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/browser/translate/translate_tab_helper.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/tabs/tab_finder.h ('k') | chrome/browser/transport_security_persister.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "chrome/browser/tab_contents/language_state.h" 9 #include "chrome/browser/tab_contents/language_state.h"
10 #include "chrome/common/translate_errors.h" 10 #include "chrome/common/translate_errors.h"
11 #include "content/browser/tab_contents/tab_contents_observer.h" 11 #include "content/browser/tab_contents/tab_contents_observer.h"
12 12
13 class TranslateTabHelper : public TabContentsObserver { 13 class TranslateTabHelper : public TabContentsObserver {
14 public: 14 public:
15 explicit TranslateTabHelper(TabContents* tab_contents); 15 explicit TranslateTabHelper(TabContents* tab_contents);
16 ~TranslateTabHelper(); 16 virtual ~TranslateTabHelper();
17 17
18 LanguageState& language_state() { return language_state_; } 18 LanguageState& language_state() { return language_state_; }
19 19
20 private: 20 private:
21 // TabContentsObserver implementation. 21 // TabContentsObserver implementation.
22 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 22 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
23 virtual void DidNavigateAnyFramePostCommit( 23 virtual void DidNavigateAnyFramePostCommit(
24 const NavigationController::LoadCommittedDetails& details, 24 const NavigationController::LoadCommittedDetails& details,
25 const ViewHostMsg_FrameNavigate_Params& params) OVERRIDE; 25 const ViewHostMsg_FrameNavigate_Params& params) OVERRIDE;
26 26
27 void OnLanguageDetermined(const std::string& language, 27 void OnLanguageDetermined(const std::string& language,
28 bool page_translatable); 28 bool page_translatable);
29 void OnPageTranslated(int32 page_id, 29 void OnPageTranslated(int32 page_id,
30 const std::string& original_lang, 30 const std::string& original_lang,
31 const std::string& translated_lang, 31 const std::string& translated_lang,
32 TranslateErrors::Type error_type); 32 TranslateErrors::Type error_type);
33 33
34 // Information about the language the page is in and has been translated to. 34 // Information about the language the page is in and has been translated to.
35 LanguageState language_state_; 35 LanguageState language_state_;
36 36
37 DISALLOW_COPY_AND_ASSIGN(TranslateTabHelper); 37 DISALLOW_COPY_AND_ASSIGN(TranslateTabHelper);
38 }; 38 };
39 39
40 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 40 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/tabs/tab_finder.h ('k') | chrome/browser/transport_security_persister.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698