net/disk_cache/file_lock.cc - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/file_lock.cc

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/file_lock.cc

diff --git a/net/disk_cache/file_lock.cc b/net/disk_cache/file_lock.cc

index 949c645d6e6f1b92ea0327ddfc9b0021a86bc8a6..6e9d9496136f13635daf740ba220241016f17e9c 100644

--- a/net/disk_cache/file_lock.cc

+++ b/net/disk_cache/file_lock.cc

@@ -12,6 +12,10 @@ FileLock::FileLock(BlockFileHeader* header) {

acquired_ = true;

}

+FileLock::~FileLock() {

+ Unlock();

void FileLock::Lock() {

if (acquired_)

return;

« no previous file with comments | « net/disk_cache/file_lock.h ('k') | net/disk_cache/in_flight_backend_io.h » ('j') | no next file with comments »