chrome/browser/net/net_log_logger.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/net_log_logger.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/net_log_logger.h

diff --git a/chrome/browser/net/net_log_logger.h b/chrome/browser/net/net_log_logger.h

index b1440b70d9fcec45b0ed77aa15bada65851d3537..9f3ff753b553e6355679f663935e83dda1314c86 100644

--- a/chrome/browser/net/net_log_logger.h

+++ b/chrome/browser/net/net_log_logger.h

@@ -23,7 +23,7 @@ class NetLogLogger : public ChromeNetLog::ThreadSafeObserver {

// Otherwise, writes to |log_path|. Uses one line per entry, for

// easy parsing.

explicit NetLogLogger(const FilePath &log_path);

- ~NetLogLogger();

+ virtual ~NetLogLogger();

// ThreadSafeObserver implementation:

virtual void OnAddEntry(net::NetLog::EventType type,

@@ -39,4 +39,3 @@ class NetLogLogger : public ChromeNetLog::ThreadSafeObserver {

};

#endif // CHROME_BROWSER_NET_NET_LOG_LOGGER_H_

« no previous file with comments | « chrome/browser/net/load_timing_observer.h ('k') | chrome/browser/net/net_pref_observer.h » ('j') | no next file with comments »