Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Side by Side Diff: chrome/browser/extensions/extension_apitest.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_APITEST_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_APITEST_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_APITEST_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_APITEST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <deque> 9 #include <deque>
10 #include <string> 10 #include <string>
(...skipping 20 matching lines...) Expand all
31 31
32 protected: 32 protected:
33 // Helper class that observes tests failing or passing. Observation starts 33 // Helper class that observes tests failing or passing. Observation starts
34 // when the class is constructed. Get the next result by calling 34 // when the class is constructed. Get the next result by calling
35 // GetNextResult() and message() if GetNextResult() return false. If there 35 // GetNextResult() and message() if GetNextResult() return false. If there
36 // are no results, this method will pump the UI message loop until one is 36 // are no results, this method will pump the UI message loop until one is
37 // received. 37 // received.
38 class ResultCatcher : public NotificationObserver { 38 class ResultCatcher : public NotificationObserver {
39 public: 39 public:
40 ResultCatcher(); 40 ResultCatcher();
41 ~ResultCatcher(); 41 virtual ~ResultCatcher();
42 42
43 // Pumps the UI loop until a notification is received that an API test 43 // Pumps the UI loop until a notification is received that an API test
44 // succeeded or failed. Returns true if the test succeeded, false otherwise. 44 // succeeded or failed. Returns true if the test succeeded, false otherwise.
45 bool GetNextResult(); 45 bool GetNextResult();
46 46
47 void RestrictToProfile(Profile* profile) { profile_restriction_ = profile; } 47 void RestrictToProfile(Profile* profile) { profile_restriction_ = profile; }
48 48
49 const std::string& message() { return message_; } 49 const std::string& message() { return message_; }
50 50
51 private: 51 private:
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 bool enable_incognito, 121 bool enable_incognito,
122 bool enable_fileaccess, 122 bool enable_fileaccess,
123 bool load_as_component); 123 bool load_as_component);
124 124
125 // Hold details of the test, set in C++, which can be accessed by 125 // Hold details of the test, set in C++, which can be accessed by
126 // javascript using chrome.test.getConfig(). 126 // javascript using chrome.test.getConfig().
127 scoped_ptr<DictionaryValue> test_config_; 127 scoped_ptr<DictionaryValue> test_config_;
128 }; 128 };
129 129
130 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_APITEST_H_ 130 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_APITEST_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/crx_installer.h ('k') | chrome/browser/extensions/extension_browser_actions_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698