Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: webkit/plugins/ppapi/ppb_audio_impl.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/plugins/npapi/webplugin_delegate_impl.h ('k') | webkit/quota/usage_tracker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_ 5 #ifndef WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_
6 #define WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_ 6 #define WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/shared_memory.h" 10 #include "base/shared_memory.h"
(...skipping 13 matching lines...) Expand all
24 namespace ppapi { 24 namespace ppapi {
25 25
26 class PluginInstance; 26 class PluginInstance;
27 27
28 // The implementation is actually in AudioConfigImpl. 28 // The implementation is actually in AudioConfigImpl.
29 class PPB_AudioConfig_Impl : public Resource, 29 class PPB_AudioConfig_Impl : public Resource,
30 public ::ppapi::AudioConfigImpl { 30 public ::ppapi::AudioConfigImpl {
31 public: 31 public:
32 // Note that you must call Init (on AudioConfigImpl) before using this class. 32 // Note that you must call Init (on AudioConfigImpl) before using this class.
33 PPB_AudioConfig_Impl(PluginInstance* instance); 33 PPB_AudioConfig_Impl(PluginInstance* instance);
34 ~PPB_AudioConfig_Impl(); 34 virtual ~PPB_AudioConfig_Impl();
35 35
36 // ResourceObjectBase overrides. 36 // ResourceObjectBase overrides.
37 virtual ::ppapi::thunk::PPB_AudioConfig_API* AsAudioConfig_API() OVERRIDE; 37 virtual ::ppapi::thunk::PPB_AudioConfig_API* AsAudioConfig_API() OVERRIDE;
38 38
39 private: 39 private:
40 DISALLOW_COPY_AND_ASSIGN(PPB_AudioConfig_Impl); 40 DISALLOW_COPY_AND_ASSIGN(PPB_AudioConfig_Impl);
41 }; 41 };
42 42
43 // Some of the backend functionality of this class is implemented by the 43 // Some of the backend functionality of this class is implemented by the
44 // AudioImpl so it can be shared with the proxy. 44 // AudioImpl so it can be shared with the proxy.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 size_t shared_memory_size_for_create_callback_; 98 size_t shared_memory_size_for_create_callback_;
99 scoped_ptr<base::SyncSocket> socket_for_create_callback_; 99 scoped_ptr<base::SyncSocket> socket_for_create_callback_;
100 100
101 DISALLOW_COPY_AND_ASSIGN(PPB_Audio_Impl); 101 DISALLOW_COPY_AND_ASSIGN(PPB_Audio_Impl);
102 }; 102 };
103 103
104 } // namespace ppapi 104 } // namespace ppapi
105 } // namespace webkit 105 } // namespace webkit
106 106
107 #endif // WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_ 107 #endif // WEBKIT_PLUGINS_PPAPI_PPB_AUDIO_IMPL_H_
OLDNEW
« no previous file with comments | « webkit/plugins/npapi/webplugin_delegate_impl.h ('k') | webkit/quota/usage_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698