Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: chrome/browser/bookmarks/bookmark_storage.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.h ('k') | chrome/browser/browsing_data_remover.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_STORAGE_H_ 5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_STORAGE_H_
6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_STORAGE_H_ 6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_STORAGE_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 // Notification the bookmark bar model is going to be deleted. If there is 97 // Notification the bookmark bar model is going to be deleted. If there is
98 // a pending save, it is saved immediately. 98 // a pending save, it is saved immediately.
99 void BookmarkModelDeleted(); 99 void BookmarkModelDeleted();
100 100
101 // ImportantFileWriter::DataSerializer 101 // ImportantFileWriter::DataSerializer
102 virtual bool SerializeData(std::string* output); 102 virtual bool SerializeData(std::string* output);
103 103
104 private: 104 private:
105 friend class base::RefCountedThreadSafe<BookmarkStorage>; 105 friend class base::RefCountedThreadSafe<BookmarkStorage>;
106 106
107 ~BookmarkStorage(); 107 virtual ~BookmarkStorage();
108 108
109 class LoadTask; 109 class LoadTask;
110 110
111 // Callback from backend with the results of the bookmark file. 111 // Callback from backend with the results of the bookmark file.
112 // This may be called multiple times, with different paths. This happens when 112 // This may be called multiple times, with different paths. This happens when
113 // we migrate bookmark data from database. 113 // we migrate bookmark data from database.
114 void OnLoadFinished(bool file_exists, 114 void OnLoadFinished(bool file_exists,
115 const FilePath& path); 115 const FilePath& path);
116 116
117 // Loads bookmark data from |file| and notifies the model when finished. 117 // Loads bookmark data from |file| and notifies the model when finished.
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 // Path to temporary file created during migrating bookmarks from history. 152 // Path to temporary file created during migrating bookmarks from history.
153 const FilePath tmp_history_path_; 153 const FilePath tmp_history_path_;
154 154
155 // See class description of BookmarkLoadDetails for details on this. 155 // See class description of BookmarkLoadDetails for details on this.
156 scoped_ptr<BookmarkLoadDetails> details_; 156 scoped_ptr<BookmarkLoadDetails> details_;
157 157
158 DISALLOW_COPY_AND_ASSIGN(BookmarkStorage); 158 DISALLOW_COPY_AND_ASSIGN(BookmarkStorage);
159 }; 159 };
160 160
161 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_STORAGE_H_ 161 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_STORAGE_H_
OLDNEW
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.h ('k') | chrome/browser/browsing_data_remover.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698