base/values.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values.h

diff --git a/base/values.h b/base/values.h

index 6fb32402b834e0243b92c8c69bca7daed58852a8..43894d15c2b7ed7ff75a478b7194110624a4c02a 100644

--- a/base/values.h

+++ b/base/values.h

@@ -355,7 +355,7 @@ class BASE_API ListValue : public Value {

typedef ValueVector::const_iterator const_iterator;

ListValue();

- ~ListValue();

+ virtual ~ListValue();

// Clears the contents of this ListValue

void Clear();

« no previous file with comments | « base/task_queue.h ('k') | chrome/browser/autocomplete/autocomplete_edit.h » ('j') | no next file with comments »