Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: chrome/browser/ui/gtk/download/download_item_gtk.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_GTK_DOWNLOAD_DOWNLOAD_ITEM_GTK_H_ 5 #ifndef CHROME_BROWSER_UI_GTK_DOWNLOAD_DOWNLOAD_ITEM_GTK_H_
6 #define CHROME_BROWSER_UI_GTK_DOWNLOAD_DOWNLOAD_ITEM_GTK_H_ 6 #define CHROME_BROWSER_UI_GTK_DOWNLOAD_DOWNLOAD_ITEM_GTK_H_
7 #pragma once 7 #pragma once
8 8
9 #include <gtk/gtk.h> 9 #include <gtk/gtk.h>
10 10
(...skipping 27 matching lines...) Expand all
38 38
39 class DownloadItemGtk : public DownloadItem::Observer, 39 class DownloadItemGtk : public DownloadItem::Observer,
40 public ui::AnimationDelegate, 40 public ui::AnimationDelegate,
41 public NotificationObserver { 41 public NotificationObserver {
42 public: 42 public:
43 // DownloadItemGtk takes ownership of |download_item_model|. 43 // DownloadItemGtk takes ownership of |download_item_model|.
44 DownloadItemGtk(DownloadShelfGtk* parent_shelf, 44 DownloadItemGtk(DownloadShelfGtk* parent_shelf,
45 BaseDownloadItemModel* download_item_model); 45 BaseDownloadItemModel* download_item_model);
46 46
47 // Destroys all widgets belonging to this DownloadItemGtk. 47 // Destroys all widgets belonging to this DownloadItemGtk.
48 ~DownloadItemGtk(); 48 virtual ~DownloadItemGtk();
49 49
50 // DownloadItem::Observer implementation. 50 // DownloadItem::Observer implementation.
51 virtual void OnDownloadUpdated(DownloadItem* download); 51 virtual void OnDownloadUpdated(DownloadItem* download);
52 virtual void OnDownloadOpened(DownloadItem* download) { } 52 virtual void OnDownloadOpened(DownloadItem* download) { }
53 53
54 // ui::AnimationDelegate implementation. 54 // ui::AnimationDelegate implementation.
55 virtual void AnimationProgressed(const ui::Animation* animation); 55 virtual void AnimationProgressed(const ui::Animation* animation);
56 56
57 // Overridden from NotificationObserver: 57 // Overridden from NotificationObserver:
58 virtual void Observe(NotificationType type, 58 virtual void Observe(NotificationType type,
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 232
233 // For canceling an in progress icon request. 233 // For canceling an in progress icon request.
234 CancelableRequestConsumerT<int, 0> icon_consumer_; 234 CancelableRequestConsumerT<int, 0> icon_consumer_;
235 235
236 // Indicates when the download has completed, so we don't redo 236 // Indicates when the download has completed, so we don't redo
237 // on-completion actions. 237 // on-completion actions.
238 bool download_complete_; 238 bool download_complete_;
239 }; 239 };
240 240
241 #endif // CHROME_BROWSER_UI_GTK_DOWNLOAD_DOWNLOAD_ITEM_GTK_H_ 241 #endif // CHROME_BROWSER_UI_GTK_DOWNLOAD_DOWNLOAD_ITEM_GTK_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/custom_button.h ('k') | chrome/browser/ui/gtk/download/download_shelf_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698