Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: chrome/browser/extensions/extension_host.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 public NotificationObserver, 44 public NotificationObserver,
45 public JavaScriptAppModalDialogDelegate { 45 public JavaScriptAppModalDialogDelegate {
46 public: 46 public:
47 class ProcessCreationQueue; 47 class ProcessCreationQueue;
48 48
49 // Enable DOM automation in created render view hosts. 49 // Enable DOM automation in created render view hosts.
50 static void EnableDOMAutomation() { enable_dom_automation_ = true; } 50 static void EnableDOMAutomation() { enable_dom_automation_ = true; }
51 51
52 ExtensionHost(const Extension* extension, SiteInstance* site_instance, 52 ExtensionHost(const Extension* extension, SiteInstance* site_instance,
53 const GURL& url, ViewType::Type host_type); 53 const GURL& url, ViewType::Type host_type);
54 ~ExtensionHost(); 54 virtual ~ExtensionHost();
55 55
56 #if defined(TOOLKIT_VIEWS) 56 #if defined(TOOLKIT_VIEWS)
57 void set_view(ExtensionView* view) { view_.reset(view); } 57 void set_view(ExtensionView* view) { view_.reset(view); }
58 const ExtensionView* view() const { return view_.get(); } 58 const ExtensionView* view() const { return view_.get(); }
59 ExtensionView* view() { return view_.get(); } 59 ExtensionView* view() { return view_.get(); }
60 #elif defined(OS_MACOSX) 60 #elif defined(OS_MACOSX)
61 const ExtensionViewMac* view() const { return view_.get(); } 61 const ExtensionViewMac* view() const { return view_.get(); }
62 ExtensionViewMac* view() { return view_.get(); } 62 ExtensionViewMac* view() { return view_.get(); }
63 #elif defined(TOOLKIT_GTK) 63 #elif defined(TOOLKIT_GTK)
64 const ExtensionViewGtk* view() const { return view_.get(); } 64 const ExtensionViewGtk* view() const { return view_.get(); }
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 // The time that the last javascript message was dismissed. 294 // The time that the last javascript message was dismissed.
295 base::TimeTicks last_javascript_message_dismissal_; 295 base::TimeTicks last_javascript_message_dismissal_;
296 296
297 // Whether to suppress all javascript messages. 297 // Whether to suppress all javascript messages.
298 bool suppress_javascript_messages_; 298 bool suppress_javascript_messages_;
299 299
300 DISALLOW_COPY_AND_ASSIGN(ExtensionHost); 300 DISALLOW_COPY_AND_ASSIGN(ExtensionHost);
301 }; 301 };
302 302
303 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 303 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_history_api.h ('k') | chrome/browser/extensions/extension_i18n_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698