Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: chrome/browser/download/download_manager.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/debugger/inspectable_tab_proxy.h ('k') | chrome/browser/download/save_package.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // The DownloadManager object manages the process of downloading, including 5 // The DownloadManager object manages the process of downloading, including
6 // updates to the history system and providing the information for displaying 6 // updates to the history system and providing the information for displaying
7 // the downloads view in the Destinations tab. There is one DownloadManager per 7 // the downloads view in the Destinations tab. There is one DownloadManager per
8 // active profile in Chrome. 8 // active profile in Chrome.
9 // 9 //
10 // Download observers: 10 // Download observers:
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 DownloadManager* observing_download_manager_; 267 DownloadManager* observing_download_manager_;
268 268
269 // The original profile's download manager. 269 // The original profile's download manager.
270 DownloadManager* observed_download_manager_; 270 DownloadManager* observed_download_manager_;
271 }; 271 };
272 272
273 friend struct BrowserThread::DeleteOnThread<BrowserThread::UI>; 273 friend struct BrowserThread::DeleteOnThread<BrowserThread::UI>;
274 friend class DeleteTask<DownloadManager>; 274 friend class DeleteTask<DownloadManager>;
275 friend class OtherDownloadManagerObserver; 275 friend class OtherDownloadManagerObserver;
276 276
277 ~DownloadManager(); 277 virtual ~DownloadManager();
278 278
279 // Called on the download thread to check whether the suggested file path 279 // Called on the download thread to check whether the suggested file path
280 // exists. We don't check if the file exists on the UI thread to avoid UI 280 // exists. We don't check if the file exists on the UI thread to avoid UI
281 // stalls from interacting with the file system. 281 // stalls from interacting with the file system.
282 void CheckIfSuggestedPathExists(int32 download_id, 282 void CheckIfSuggestedPathExists(int32 download_id,
283 DownloadStateInfo state, 283 DownloadStateInfo state,
284 const FilePath& default_path); 284 const FilePath& default_path);
285 285
286 // Called on the UI thread once the DownloadManager has determined whether the 286 // Called on the UI thread once the DownloadManager has determined whether the
287 // suggested file path exists. 287 // suggested file path exists.
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 // The "Save As" dialog box used to ask the user where a file should be 407 // The "Save As" dialog box used to ask the user where a file should be
408 // saved. 408 // saved.
409 scoped_refptr<SelectFileDialog> select_file_dialog_; 409 scoped_refptr<SelectFileDialog> select_file_dialog_;
410 410
411 scoped_ptr<OtherDownloadManagerObserver> other_download_manager_observer_; 411 scoped_ptr<OtherDownloadManagerObserver> other_download_manager_observer_;
412 412
413 DISALLOW_COPY_AND_ASSIGN(DownloadManager); 413 DISALLOW_COPY_AND_ASSIGN(DownloadManager);
414 }; 414 };
415 415
416 #endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_H_ 416 #endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_H_
OLDNEW
« no previous file with comments | « chrome/browser/debugger/inspectable_tab_proxy.h ('k') | chrome/browser/download/save_package.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698