Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: net/base/cookie_monster.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/base/cert_verifier.h ('k') | net/base/dnsrr_resolver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Brought to you by the letter D and the number 2. 5 // Brought to you by the letter D and the number 2.
6 6
7 #ifndef NET_BASE_COOKIE_MONSTER_H_ 7 #ifndef NET_BASE_COOKIE_MONSTER_H_
8 #define NET_BASE_COOKIE_MONSTER_H_ 8 #define NET_BASE_COOKIE_MONSTER_H_
9 #pragma once 9 #pragma once
10 10
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 // to global garbage collection. 334 // to global garbage collection.
335 static const int kSafeFromGlobalPurgeDays; 335 static const int kSafeFromGlobalPurgeDays;
336 336
337 // Default value for key and expiry scheme scheme. 337 // Default value for key and expiry scheme scheme.
338 static const ExpiryAndKeyScheme expiry_and_key_default_ = 338 static const ExpiryAndKeyScheme expiry_and_key_default_ =
339 EKS_KEEP_RECENT_AND_PURGE_ETLDP1; 339 EKS_KEEP_RECENT_AND_PURGE_ETLDP1;
340 340
341 // Record statistics every kRecordStatisticsIntervalSeconds of uptime. 341 // Record statistics every kRecordStatisticsIntervalSeconds of uptime.
342 static const int kRecordStatisticsIntervalSeconds = 10 * 60; 342 static const int kRecordStatisticsIntervalSeconds = 10 * 60;
343 343
344 ~CookieMonster(); 344 virtual ~CookieMonster();
345 345
346 bool SetCookieWithCreationTime(const GURL& url, 346 bool SetCookieWithCreationTime(const GURL& url,
347 const std::string& cookie_line, 347 const std::string& cookie_line,
348 const base::Time& creation_time); 348 const base::Time& creation_time);
349 349
350 // Called by all non-static functions to ensure that the cookies store has 350 // Called by all non-static functions to ensure that the cookies store has
351 // been initialized. This is not done during creating so it doesn't block 351 // been initialized. This is not done during creating so it doesn't block
352 // the window showing. 352 // the window showing.
353 // Note: this method should always be called with lock_ held. 353 // Note: this method should always be called with lock_ held.
354 void InitIfNecessary() { 354 void InitIfNecessary() {
(...skipping 465 matching lines...) Expand 10 before | Expand all | Expand 10 after
820 private: 820 private:
821 DISALLOW_COPY_AND_ASSIGN(PersistentCookieStore); 821 DISALLOW_COPY_AND_ASSIGN(PersistentCookieStore);
822 }; 822 };
823 823
824 class CookieList : public std::vector<CookieMonster::CanonicalCookie> { 824 class CookieList : public std::vector<CookieMonster::CanonicalCookie> {
825 }; 825 };
826 826
827 } // namespace net 827 } // namespace net
828 828
829 #endif // NET_BASE_COOKIE_MONSTER_H_ 829 #endif // NET_BASE_COOKIE_MONSTER_H_
OLDNEW
« no previous file with comments | « net/base/cert_verifier.h ('k') | net/base/dnsrr_resolver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698