Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: webkit/blob/view_blob_internals_job.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/appcache/view_appcache_internals_job.h ('k') | webkit/glue/weburlloader_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_BLOB_VIEW_BLOB_INTERNALS_JOB_H_ 5 #ifndef WEBKIT_BLOB_VIEW_BLOB_INTERNALS_JOB_H_
6 #define WEBKIT_BLOB_VIEW_BLOB_INTERNALS_JOB_H_ 6 #define WEBKIT_BLOB_VIEW_BLOB_INTERNALS_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/task.h" 10 #include "base/task.h"
(...skipping 16 matching lines...) Expand all
27 BlobStorageController* blob_storage_controller); 27 BlobStorageController* blob_storage_controller);
28 28
29 virtual void Start(); 29 virtual void Start();
30 virtual bool GetData(std::string* mime_type, 30 virtual bool GetData(std::string* mime_type,
31 std::string* charset, 31 std::string* charset,
32 std::string* data) const; 32 std::string* data) const;
33 virtual bool IsRedirectResponse(GURL* location, int* http_status_code); 33 virtual bool IsRedirectResponse(GURL* location, int* http_status_code);
34 virtual void Kill(); 34 virtual void Kill();
35 35
36 private: 36 private:
37 ~ViewBlobInternalsJob(); 37 virtual ~ViewBlobInternalsJob();
38 38
39 void DoWorkAsync(); 39 void DoWorkAsync();
40 void GenerateHTML(std::string* out) const; 40 void GenerateHTML(std::string* out) const;
41 static void GenerateHTMLForBlobData(const BlobData& blob_data, 41 static void GenerateHTMLForBlobData(const BlobData& blob_data,
42 std::string* out); 42 std::string* out);
43 43
44 BlobStorageController* blob_storage_controller_; 44 BlobStorageController* blob_storage_controller_;
45 ScopedRunnableMethodFactory<ViewBlobInternalsJob> method_factory_; 45 ScopedRunnableMethodFactory<ViewBlobInternalsJob> method_factory_;
46 46
47 DISALLOW_COPY_AND_ASSIGN(ViewBlobInternalsJob); 47 DISALLOW_COPY_AND_ASSIGN(ViewBlobInternalsJob);
48 }; 48 };
49 49
50 } // namespace webkit_blob 50 } // namespace webkit_blob
51 51
52 #endif // WEBKIT_BLOB_VIEW_BLOB_INTERNALS_JOB_H_ 52 #endif // WEBKIT_BLOB_VIEW_BLOB_INTERNALS_JOB_H_
OLDNEW
« no previous file with comments | « webkit/appcache/view_appcache_internals_job.h ('k') | webkit/glue/weburlloader_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698