Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: webkit/appcache/view_appcache_internals_job.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/appcache/appcache_update_job.h ('k') | webkit/blob/view_blob_internals_job.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_APPCACHE_VIEW_APPCACHE_INTERNALS_JOB_H_ 5 #ifndef WEBKIT_APPCACHE_VIEW_APPCACHE_INTERNALS_JOB_H_
6 #define WEBKIT_APPCACHE_VIEW_APPCACHE_INTERNALS_JOB_H_ 6 #define WEBKIT_APPCACHE_VIEW_APPCACHE_INTERNALS_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "net/url_request/url_request_simple_job.h" 10 #include "net/url_request/url_request_simple_job.h"
(...skipping 16 matching lines...) Expand all
27 virtual void Start(); 27 virtual void Start();
28 28
29 virtual bool GetData(std::string* mime_type, 29 virtual bool GetData(std::string* mime_type,
30 std::string* charset, 30 std::string* charset,
31 std::string* data) const; 31 std::string* data) const;
32 32
33 // Overridden method from net::URLRequestJob. 33 // Overridden method from net::URLRequestJob.
34 virtual bool IsRedirectResponse(GURL* location, int* http_status_code); 34 virtual bool IsRedirectResponse(GURL* location, int* http_status_code);
35 35
36 private: 36 private:
37 ~ViewAppCacheInternalsJob(); 37 virtual ~ViewAppCacheInternalsJob();
38 38
39 void AppCacheDone(int rv); 39 void AppCacheDone(int rv);
40 40
41 // Adds HTML from appcache information to out. 41 // Adds HTML from appcache information to out.
42 void GenerateHTMLAppCacheInfo(std::string* out) const; 42 void GenerateHTMLAppCacheInfo(std::string* out) const;
43 void GetAppCacheInfoAsync(); 43 void GetAppCacheInfoAsync();
44 void RemoveAppCacheInfoAsync(const std::string& manifest_url_spec); 44 void RemoveAppCacheInfoAsync(const std::string& manifest_url_spec);
45 45
46 // This is a common callback for both remove and getinfo for appcache. 46 // This is a common callback for both remove and getinfo for appcache.
47 scoped_refptr<net::CancelableCompletionCallback<ViewAppCacheInternalsJob> > 47 scoped_refptr<net::CancelableCompletionCallback<ViewAppCacheInternalsJob> >
48 appcache_done_callback_; 48 appcache_done_callback_;
49 49
50 scoped_refptr<AppCacheInfoCollection> info_collection_; 50 scoped_refptr<AppCacheInfoCollection> info_collection_;
51 // Not owned. 51 // Not owned.
52 AppCacheService* appcache_service_; 52 AppCacheService* appcache_service_;
53 53
54 DISALLOW_COPY_AND_ASSIGN(ViewAppCacheInternalsJob); 54 DISALLOW_COPY_AND_ASSIGN(ViewAppCacheInternalsJob);
55 }; 55 };
56 56
57 } // namespace appcache 57 } // namespace appcache
58 58
59 #endif // WEBKIT_APPCACHE_VIEW_APPCACHE_INTERNALS_JOB_H_ 59 #endif // WEBKIT_APPCACHE_VIEW_APPCACHE_INTERNALS_JOB_H_
OLDNEW
« no previous file with comments | « webkit/appcache/appcache_update_job.h ('k') | webkit/blob/view_blob_internals_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698