chrome/browser/sync/util/extensions_activity_monitor.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/util/extensions_activity_monitor.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/util/extensions_activity_monitor.h

diff --git a/chrome/browser/sync/util/extensions_activity_monitor.h b/chrome/browser/sync/util/extensions_activity_monitor.h

index 3cce2385ec5f64111a82e760d680a5184da42892..6d085e63ef60f876fee0ea65549dc8c33d375798 100644

--- a/chrome/browser/sync/util/extensions_activity_monitor.h

+++ b/chrome/browser/sync/util/extensions_activity_monitor.h

@@ -46,7 +46,7 @@ class ExtensionsActivityMonitor : public NotificationObserver {

// Creates an ExtensionsActivityMonitor to monitor extensions activities on

// BrowserThread::UI.

ExtensionsActivityMonitor();

- ~ExtensionsActivityMonitor();

+ virtual ~ExtensionsActivityMonitor();

// Fills |buffer| with snapshot of current records in constant time by

// swapping. This is done mutually exclusively w.r.t methods of this class.