net/base/cookie_monster.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/cookie_monster.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/cookie_monster.h

diff --git a/net/base/cookie_monster.h b/net/base/cookie_monster.h

index 58b13d4d4325241d54d517be1738d707833c90ae..c3943ac10fee4696981131d432ff9b18a4b9c471 100644

--- a/net/base/cookie_monster.h

+++ b/net/base/cookie_monster.h

@@ -341,7 +341,7 @@ class NET_API CookieMonster : public CookieStore {

// Record statistics every kRecordStatisticsIntervalSeconds of uptime.

static const int kRecordStatisticsIntervalSeconds = 10 * 60;

- ~CookieMonster();

+ virtual ~CookieMonster();

bool SetCookieWithCreationTime(const GURL& url,

const std::string& cookie_line,

« no previous file with comments | « net/base/cert_verifier.h ('k') | net/base/dnsrr_resolver.h » ('j') | no next file with comments »