chrome/browser/ui/cocoa/constrained_window_mac.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window_mac.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/constrained_window_mac.h

diff --git a/chrome/browser/ui/cocoa/constrained_window_mac.h b/chrome/browser/ui/cocoa/constrained_window_mac.h

index 2de151af58cc09d86998bab7f31474200ebb91c9..60425c01e514571c805ee3fb052ed4750aeff1e2 100644

--- a/chrome/browser/ui/cocoa/constrained_window_mac.h

+++ b/chrome/browser/ui/cocoa/constrained_window_mac.h

@@ -83,7 +83,7 @@ class ConstrainedWindowMacDelegateCustomSheet

public:

ConstrainedWindowMacDelegateCustomSheet();

ConstrainedWindowMacDelegateCustomSheet(id delegate, SEL didEndSelector);

- ~ConstrainedWindowMacDelegateCustomSheet();

+ virtual ~ConstrainedWindowMacDelegateCustomSheet();

protected:

// For when you need to delay initalization after the constructor call.

@@ -146,4 +146,3 @@ class ConstrainedWindowMac : public ConstrainedWindow {

};

#endif // CHROME_BROWSER_UI_COCOA_CONSTRAINED_WINDOW_MAC_H_