Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: chrome/browser/bookmarks/bookmark_html_writer.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_ 5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_
6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_ 6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <list> 9 #include <list>
10 #include <map> 10 #include <map>
(...skipping 23 matching lines...) Expand all
34 // then starts Writer which outputs bookmarks and favicons to html file. 34 // then starts Writer which outputs bookmarks and favicons to html file.
35 // Should be used only by WriteBookmarks function. 35 // Should be used only by WriteBookmarks function.
36 class BookmarkFaviconFetcher: public NotificationObserver { 36 class BookmarkFaviconFetcher: public NotificationObserver {
37 public: 37 public:
38 // Map of URL and corresponding favicons. 38 // Map of URL and corresponding favicons.
39 typedef std::map<std::string, scoped_refptr<RefCountedMemory> > URLFaviconMap; 39 typedef std::map<std::string, scoped_refptr<RefCountedMemory> > URLFaviconMap;
40 40
41 BookmarkFaviconFetcher(Profile* profile, 41 BookmarkFaviconFetcher(Profile* profile,
42 const FilePath& path, 42 const FilePath& path,
43 BookmarksExportObserver* observer); 43 BookmarksExportObserver* observer);
44 ~BookmarkFaviconFetcher(); 44 virtual ~BookmarkFaviconFetcher();
45 45
46 // Executes bookmark export process. 46 // Executes bookmark export process.
47 void ExportBookmarks(); 47 void ExportBookmarks();
48 48
49 // NotificationObserver implementation. 49 // NotificationObserver implementation.
50 virtual void Observe(NotificationType type, 50 virtual void Observe(NotificationType type,
51 const NotificationSource& source, 51 const NotificationSource& source,
52 const NotificationDetails& details); 52 const NotificationDetails& details);
53 53
54 private: 54 private:
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 // thread is used. 98 // thread is used.
99 // Before writing to the file favicons are fetched on the main thread. 99 // Before writing to the file favicons are fetched on the main thread.
100 // TODO(sky): need a callback on failure. 100 // TODO(sky): need a callback on failure.
101 void WriteBookmarks(Profile* profile, 101 void WriteBookmarks(Profile* profile,
102 const FilePath& path, 102 const FilePath& path,
103 BookmarksExportObserver* observer); 103 BookmarksExportObserver* observer);
104 104
105 } // namespace bookmark_html_writer 105 } // namespace bookmark_html_writer
106 106
107 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_ 107 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_HTML_WRITER_H_
OLDNEW
« no previous file with comments | « chrome/browser/background_application_list_model.h ('k') | chrome/browser/bookmarks/bookmark_storage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698