chrome/browser/webdata/web_database_table.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/webdata/web_database_table.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/webdata/web_database_table.h

diff --git a/chrome/browser/webdata/web_database_table.h b/chrome/browser/webdata/web_database_table.h

index 5bb95b96e7c0f8f0e9b61bfcdd29418c1bcc1322..ea3c5ec43ba885dbdbd8dff3271b501855410a5b 100644

--- a/chrome/browser/webdata/web_database_table.h

+++ b/chrome/browser/webdata/web_database_table.h

@@ -16,10 +16,7 @@ class WebDatabaseTable {

protected:

explicit WebDatabaseTable(sql::Connection* db, sql::MetaTable* meta_table)

: db_(db), meta_table_(meta_table) {}

- virtual ~WebDatabaseTable() {

- db_ = NULL;

- meta_table_ = NULL;

- };

+ virtual ~WebDatabaseTable();

// Attempts to initialize the table and returns true if successful.

virtual bool Init() = 0;